Skip to content

fix dark images - #2913

Open
chgeo wants to merge 1 commit into
mainfrom
fix-dark
Open

chgeo wants to merge 1 commit into
mainfrom
fix-dark

Conversation

@chgeo

@chgeo chgeo commented Sep 22, 2026

Copy link
Copy Markdown
Member

No description provided.

@hyperspace-pr-bot

Copy link
Copy Markdown
Contributor

Control Panel

Hi, I'm an AI-powered Review Bot that helps you with summarizing and reviewing pull requests.
To interact with me, just use the following actions:

  • 📝 Summarize PR
  • 🔍 Review
  • 🗑️ Delete all bot comments and reviews

@chgeo
chgeo enabled auto-merge September 22, 2026 10:06

@danjoa danjoa left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm...

  1. For the first two I explicitly added the {.ignore-dark} because I wanted it like that. → what's the problem?
  2. Also these look perfect (for me, in Safari) → why should we need that strange .raw thing?

Btw: that .raw thing created problems in the past. What problem should it address?

@chgeo

chgeo commented Oct 6, 2026

Copy link
Copy Markdown
Member Author
  1. For the first two I explicitly added the {.ignore-dark} because I wanted it like that. → what's the problem?

They just look quite bright in dark mode.
image

But if that's deliberate, ok. I suggest to put a comment there so that we know later about this decision.

  1. Also these look perfect (for me, in Safari) → why should we need that strange .raw thing?

They only look perfect in Safari. Both Chrome and Firefox render them badly:

image image

?raw inlines SVGs, so that they are rendered correctly.

Btw: that .raw thing created problems in the past. What problem should it address?

@swaldmann Do you know which problems there were? The difference that I can see is that the svg can no longer be copied/exported by a user because it's inlined.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants