[GITP-25] Block unsafe underscored git kwargs#2
Open
0xMorph wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simulated fix for Apex finding GITP-25.
This blocks unsafe top-level
git(...)option kwargs before underscored Python names are transformed into command-line options. In particular,c=...andconfig=...now raiseUnsafeOptionErrorinstead of becoming-c/--config, which can re-enable config-driven command execution such ascore.sshCommand.Validation attempted:
pytest -q test/test_git.py -k 'unsafe_options or unsafe_config_kwargs'.Result: blocked in the temp clone because the repository pytest config requires
pytest-cov(--cov=git) and that plugin is not installed.