proposal: set glob_matcher: doublestar in lefthook configuration (more standard + avoids glob surprises) #920
moskalakamil
started this conversation in
Ideas
Replies: 1 comment
-
|
cc @satya164 |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
hey 👋
small proposal for the lefthook template config in
builder-bob: let’s switch tocontext
right now the template uses:
right here
and with the default matcher (

gobwas) this ends up matching subdirectories too (likesrc/foo.ts).which is expected for the library, but unexpected according to Lefthook docs / common glob expectations.
docs:
https://lefthook.dev/configuration/glob_matcher.html
why change?
gobwasworks, but it’s kinda annoying once configs get bigger:doublestaris basically the “standard glob mental model” most tooling uses, so:proposal
what do you think about changing the lefthook configurtion to
glob_matcher: doublestar?happy to open a PR if you’re ok with it 🚀
Beta Was this translation helpful? Give feedback.
All reactions