fix: correct off-by-one error in rolling period booking limit #26196
+58
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kartik-212004 is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
github-actions
bot
added
High priority
![cubic-dev-ai[bot]](/s/com/githubusercontent/avatars/G.https/in/1082092?s=60&v=4){kind=small}
| if (periodData?.periodType === "ROLLING" && periodData.periodDays) { | ||
| const today = dayjs(); | ||
| const periodDays = periodData.periodDays; | ||
| const maxBookableDate = today.add(Math.max(0, periodDays - 1), "day"); |
Member
There was a problem hiding this comment.
looks like the current implementation always uses calendar days, are we not considering business days?
also consider using the existing utilities
Contributor
Author
There was a problem hiding this comment.
now using periodCountCalendarDays to determine the calculation method
dhairyashiil
requested changes
Dec 26, 2025
Member
dhairyashiil
left a comment
dhairyashiil
left a comment
There was a problem hiding this comment.
left one comment, please check. let me know what you think
Contributor
Author
I have addressed the suggested changes |
kartik-212004
force-pushed
the
fix/same-day-booking-off-by-one
branch
from
7f0a7e9 to
2d6a1cc
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes off-by-one error in rolling period booking limit calculation where setting "1 calendar day" would incorrectly allow booking for 2 days instead of just today.
Visual Demo (For contributors especially)
Before:
https://www.loom.com/share/3936ca376d3843d290022e74f7b3d194
After:
https://www.loom.com/share/0459760a190b43709d47d4ec3a7c749d
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?