Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: brick/math
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: brick/math
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: ieee754
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 9 commits
  • 4 files changed
  • 1 contributor

Commits on Apr 17, 2019

  1. Draft implementation of IEEE 754 parsing

    @BenMorel
    BenMorel committed Apr 17, 2019
    Configuration menu
    Copy the full SHA
    07e0448 View commit details
    Browse the repository at this point in the history

  2. Improve BigNumber::convertFloat() performance 

    We don't need exactlyDividedBy() and its multiple divisions, we're only dealing with powers of 2 so we can use dividedBy() with the exponent as maximum scale (each division by 2 yields at most 1 extra digit).
    @BenMorel
    BenMorel committed Apr 17, 2019
    Configuration menu
    Copy the full SHA
    b8f5101 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2019

  1. Handle zero, infinity and NaN

    @BenMorel
    BenMorel committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    45b4c01 View commit details
    Browse the repository at this point in the history

  2. Fix tests for new float handling

    @BenMorel
    BenMorel committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    29abf4d View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2019

  1. Tests for BigNumber::of() with float

    @BenMorel
    BenMorel committed Apr 19, 2019
    Configuration menu
    Copy the full SHA
    bb27603 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2019

  1. Refactor BigNumber::convertFloat()

    @BenMorel
    BenMorel committed Apr 20, 2019
    Configuration menu
    Copy the full SHA
    8363666 View commit details
    Browse the repository at this point in the history

  2. Add support for subnormal IEEE 754 numbers

    @BenMorel
    BenMorel committed Apr 20, 2019
    Configuration menu
    Copy the full SHA
    b469fe0 View commit details
    Browse the repository at this point in the history

  3. Add tests for PHP_FLOAT_MIN and PHP_FLOAT_MAX 

    Note: as far as I know, PHP uses 64-bit IEEE 754 (double) on all platforms, so these constants should return the same values everywhere.
    @BenMorel
    BenMorel committed Apr 20, 2019
    Configuration menu
    Copy the full SHA
    aed6019 View commit details
    Browse the repository at this point in the history

  4. Replace PHP_FLOAT_* tests with hex values 

    These constants are not available in PHP 7.1.
    @BenMorel
    BenMorel committed Apr 20, 2019
    Configuration menu
    Copy the full SHA
    12e761e View commit details
    Browse the repository at this point in the history
Loading