Skip to content

Conversation

@mwwoda
Copy link
Contributor

@mwwoda mwwoda commented Aug 6, 2025

  • add agent support to ask
  • fix examples of passing agent to the command - they should use camelCase
  • bump ts-sdk-gen and fix imports

@coveralls
Copy link

coveralls commented Aug 6, 2025

Pull Request Test Coverage Report for Build 16807830811

Details

  • 24 of 26 (92.31%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.04%) to 85.498%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/commands/ai/ask.js 24 26 92.31%
Files with Coverage Reduction New Missed Lines %
src/commands/files/zip.js 1 81.03%
Totals Coverage Status
Change from base Build 16565836307: -0.04%
Covered Lines: 4592
Relevant Lines: 5179

💛 - Coveralls

Pask423
Pask423 previously approved these changes Aug 6, 2025
});
await this.output(answer);
let answer = await this.tsClient.ai.createAiAsk(options);
delete answer.rawData;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why delete ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

response from our ts-sdk-gen includes also rawData field which is populated with raw json that was returned from the API. If we would return the response as is, it would contain redundant fields which could confuse cli users.

@mwwoda mwwoda merged commit 095f411 into main Aug 7, 2025
13 checks passed
@mwwoda mwwoda deleted the add-agent-support-to-ai-ask branch August 7, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants