[SM-2094] Adding prefix to machine accounts - #8372
cd-bitwarden wants to merge 2 commits into
Conversation
🤖 Bitwarden Claude Code ReviewOverall Assessment: APPROVE Reviewed the Code Review DetailsNo findings. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8372 +/- ##
=======================================
Coverage 64.52% 64.52%
=======================================
Files 2480 2480
Lines 106117 106122 +5
Branches 9625 9626 +1
=======================================
+ Hits 68470 68474 +4
- Misses 35308 35309 +1
Partials 2339 2339 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
🎟️ Tracking
https://bitwarden.atlassian.net/browse/SM-2093
📔 Objective
Add a prefix to newly created Machine Accounts "bw_"
TODO:
Ensure documentation referencing Machine Accounts communicates that old machine account names will not have this prefix - but new ones will. Both formats will function the same, and we also need to add this same context into the next release notes so that if a user happens to run into an issue where they were receiving the machine account from us and running into an error with their own code (maybe it was looking for 30 chars instead of 33) that we have this easily discoverable.
Notes
This PR was originally created by @maxkpower, and coauthored with by @cd-bitwarden