Skip to content

chore: Add machine account token prefix feature flag - #8368

Draft
maxkpower wants to merge 1 commit into
mainfrom
sm-2093-machine-account-token-prefix-flag
Draft

maxkpower wants to merge 1 commit into
mainfrom
sm-2093-machine-account-token-prefix-flag

Conversation

@maxkpower

@maxkpower maxkpower commented Sep 16, 2026

Copy link
Copy Markdown

🎟️ Tracking

SM-2093, SM-2094

📔 Objective

Adds the Sm2093MachineAccountTokenPrefix feature flag (sm-2093-machine-account-token-prefix) to FeatureFlagKeys. This is infrastructure only — no behavior changes yet. It exists so the token-generation change in the stacked PR (#8369) can ship dark and be enabled independently.

@maxkpower
maxkpower added this pull request to stack #8370 September 16, 2026 22:20
@maxkpower maxkpower added the ai-review Request a Claude code review label Sep 16, 2026
@maxkpower maxkpower changed the title sm 2093 machine account token prefix flag chore: Add machine account token prefix feature flag Sep 16, 2026
@github-actions

github-actions Bot commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

This PR adds a single feature flag constant, Sm2093MachineAccountTokenPrefix (sm-2093-machine-account-token-prefix), to the Secrets Manager section of FeatureFlagKeys in src/Core/Constants.cs. The key string follows the established <ticket>-<description> kebab-case convention, and neither the constant name nor its value collides with any of the 163 existing entries. No behavior is gated by the flag in this change, which matches the stated infrastructure-only intent; consumption lands in the follow-up PR. No security, correctness, or breaking-change concerns identified.

Code Review Details

No findings.

@codecov

codecov Bot commented Sep 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.49%. Comparing base (7673949) to head (0c9f051).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8368   +/-   ##
=======================================
  Coverage   64.48%   64.49%           
=======================================
  Files        2480     2480           
  Lines      106110   106110           
  Branches     9627     9627           
=======================================
+ Hits        68429    68435    +6     
+ Misses      35341    35337    -4     
+ Partials     2340     2338    -2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Request a Claude code review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant