Do not translate file extensions

[hebasto]

File extensions are untranslatable by their nature.

[jarolrod]

ACK 6af0a9a

Nice catch, this will help prevent any unintended translations

[jonatack]

Tested ACK 6af0a9a

Two questions: (a) does this change require translators to update every language? (b) Testing this patch, I don't see the file extensions in the dialogs. I then built master and I don't see the extensions there either 🤔 (checked in default and in French)

src/qt/locale/bitcoin_fr.ts:1574:        <source>Partially Signed Transaction (Binary) (*.psbt)</source>
src/qt/locale/bitcoin_fr.ts:1575:        <translation>Transaction signée partiellement (fichier binaire) (*.psbt)</translation>
src/qt/locale/bitcoin_fr.ts:2557:        <source>Partially Signed Transaction (Binary) (*.psbt)</source>
src/qt/locale/bitcoin_fr.ts:2558:        <translation>Transaction signée partiellement (fichier binaire) (*.psbt)</translation>
src/qt/locale/bitcoin_fr.ts:3496:        <source>Partially Signed Transaction (*.psbt)</source>
src/qt/locale/bitcoin_fr.ts:3497:        <translation>Transaction signée partiellement (*.psbt)</translation>

[hebasto]

(a) does this change require translators to update every language?

Yes. I'd say that each translator updates her language :)

(b) Testing this patch, I don't see the file extensions in the dialogs. I then built master and I don't see the extensions there either thinking (checked in default and in French)

See GUIUtil::getSaveFileName implementation.

[hebasto]

Updated 6af0a9a -> 5fe0ff3 (pr220.01 -> pr220.02, diff):

• addressed @luke-jr's comment
• minimized diff

[hebasto]

Could you suggest a good variant of annotation?

On Thu, 25 Feb 2021 at 00:18 Luke Dashjr ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In src/qt/psbtoperationsdialog.cpp <#220 (comment)>: > @@ -141,7 +141,7 @@ void PSBTOperationsDialog::saveTransaction() { filename_suggestion.append(".psbt"); QString filename = GUIUtil::getSaveFileName(this, tr("Save Transaction Data"), filename_suggestion, - tr("Partially Signed Transaction (Binary) (*.psbt)"), &selected_filter); + tr("Partially Signed Transaction (Binary)") + QLatin1String(" (*.psbt)"), &selected_filter); Annotate the tr here and later too? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#220 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AH3PXPWTEF7VBYA6M57P7L3TAV3MDANCNFSM4YCWAUUA> .

--

…

-- Hennadii Stepanov

[hebasto]

Updated 5fe0ff3 -> d4ed848 (pr220.02 -> pr220.03, diff):

• added disambiguation strings for PSBT translations as suggested by @luke-jr

[jonatack]

re-ACK d4ed848

(IDK if the "Wallet Data" ts string should be annotated as well or if it's self-evident.)

[Talkless]

Concept ACK. I agree to @luke-jr that one annotation is missing.

[hebasto]

Updated d4ed848 -> 88df300 (pr220.03 -> pr220.04, diff).

Now each of changed translation has own disambiguation string.

[Talkless]

tACK 88df300, tested on Debian Sid with Qt 5.15.2. Tested all filters except for .psbt.

[jarolrod]

re-ACK 88df300

when to use and how to place disambiguation strings is another thing to add to the Qt dev notes

[hebasto]

@luke-jr @laanwj

Some things appear unclear to me.

1. Does the non-default disambiguation argument, which is passed to the tr function, is visible to translators on transifex?

2. What are other options to make designated notes to translators on transifex?
   Do "Translator Comments" work in such a manner?

---

In the meantime, converting this pr to a draft.

[laanwj]

Concept and code review ACK 88df300

Does the non-default disambiguation argument, which is passed to the tr function, is visible to translators on transifex?
What are other options to make designated notes to translators on transifex?
Do "Translator Comments" work in such a manner?

I think those are great questions. I do not know the answer though. Maybe @wtogami knows who can weigh in—from what i remember he knows some people at Transifex.

[hebasto]

Even if disambiguation arguments won't actually help translators, they won't hurt.

As already many ACKs are collected, reverted back from "Draft" to "Ready for review".

[laanwj]

At least the comment makes it into the xml, that's one part of it being picked up

     <message>
         <location line="+1"/>
-        <source>Comma separated file (*.csv)</source>
+        <source>Comma separated file</source>
+        <comment>Name of CSV file format</comment>
         <translation type="unfinished"></translation>
     </message>