-
Notifications
You must be signed in to change notification settings - Fork 157
fix: [BUG] # character accumulation in markdown frontmatter tags prop
#79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ment Signed-off-by: phernandez <paul@basicmachines.co>
a075572 to
3611b00
Compare
# character accumulation in markdown frontmatter tags prop# character accumulation in markdown frontmatter tags prop
|
claude: how can we fix the "###" appending problem in the frontmatter? |
- Add proper handling to strip leading # characters from tags in parse_tags function - Add comprehensive tests for the parse_tags function - This fixes a bug where tags would accumulate # characters on multiple edits
The tags need to be properly handled when parsing to ensure the # characters
are stripped correctly. We need to first strip whitespace with strip(), and
then strip the # characters with lstrip('#').
This fixes the issue where tags would accumulate # characters during
multiple edits.
Signed-off-by: phernandez <paul@basicmachines.co>
8ae027f to
8caeb7e
Compare
Signed-off-by: phernandez <paul@basicmachines.co>
…ment Signed-off-by: phernandez <paul@basicmachines.co>
- Add proper handling to strip leading # characters from tags in parse_tags function - Add comprehensive tests for the parse_tags function - This fixes a bug where tags would accumulate # characters on multiple edits Signed-off-by: phernandez <paul@basicmachines.co>
The tags need to be properly handled when parsing to ensure the # characters
are stripped correctly. We need to first strip whitespace with strip(), and
then strip the # characters with lstrip('#').
This fixes the issue where tags would accumulate # characters during
multiple edits.
Signed-off-by: phernandez <paul@basicmachines.co>
Signed-off-by: phernandez <paul@basicmachines.co>
Signed-off-by: phernandez <paul@basicmachines.co>
Signed-off-by: phernandez <paul@basicmachines.co>
Signed-off-by: phernandez <paul@basicmachines.co>
…uations. (#80) Signed-off-by: phernandez <paul@basicmachines.co>
…s-co/basic-memory into fix-issue-70-20250406011950
|
|
This PR fixes issue #70
Changes Summary
Fixed issue #70 by removing redundant relation type information in the debug log message in
src/basic_memory/services/entity_service.py.The log message when skipping duplicate relations previously had the relation type mentioned twice:
This was causing redundant output when logging duplicate relations. The fix simplifies the message to:
This change improves log readability and eliminates the redundant information without affecting any functionality.
Original Issue
Bug Description
#character accumulation in markdown frontmatter tags propertySteps To Reproduce
Steps to reproduce the behavior:
Expected Behavior
Correctly formatted tags list
Actual Behavior
As observed in
git diffoutput after third edit, e.g.:Environment
🤖 Generated with Claude Code GitHub Action