Merged
Conversation
Feeds is a string and Tags is a string array. The changes passed unit tests.
Shows that the parameters actually filter down the results.
Trekkan
pushed a commit
to Trekkan/SteamWebAPI2
that referenced
this pull request
Mar 22, 2021
* Accommodate Changes to Add "Feeds" and "Tags" as SteamNews Parameters Feeds is a string and Tags is a string array. The changes passed unit tests. * Adding Parameter Examples Shows that the parameters actually filter down the results.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the additional parameters supported by ISteamNews/GetNewsForApp. Made sure to utilize the SteamNewsTests unit test to make sure it didn't break as well as ran the calls with additional parameters (which I left in, uncommented) to make sure that they reduced the number of results and functioned as expected.