Repository navigation
fix(parser): accept SES events without common headers or invocation type - #8768
Conversation
leandrodamascena
left a comment
There was a problem hiding this comment.
Thanks @Manishram-ai! This one I couldn't check against a live receipt rule, inbound SES needs a verified domain with MX records and I don't have one on the test account, so I'm going with the SES docs and the real event from the TypeScript issue, which agree with you. The data class returning None instead of raising KeyError is the same call we made for SQS and Transfer Family in 3.40.0. Goes out in 3.41.0, no need to rebase, you'll be in the release notes.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #8768 +/- ##
========================================
Coverage 97.17% 97.17%
========================================
Files 323 323
Lines 16606 16606
Branches 1504 1504
========================================
Hits 16137 16137
Misses 328 328
Partials 141 141 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
d07a9c2
into
aws-powertools:develop



Issue number:
closes #8767
Summary
Changes
SesReceiptAction.invocationTypeacceptsRequestResponseas well asEvent, and is optional. The SES docs list both values, and the captured event in Bug: SesSchema rejects documented SES receipt events powertools-lambda-typescript#5771 doesn't have it.SesMailCommonHeadersis optional now. SES only sends the headers the email has, so an email sent only to BCC recipients has noto.SESEventdata class,toandget_fromreturn[]when the header is missing, likeccandbccalready do.return_path,date,message_id,subjectandinvocation_typereturnNoneinstead of raisingKeyError, so their return types change fromstrtostr | None.This is the same fix as aws-powertools/powertools-lambda-typescript#5772. The
replyTopart of that PR was already done here in #8525.User experience
Today, events from a Lambda action invoked with
RequestResponse, and emails without a To or Subject header, fail with aValidationErrorin the parser and aKeyErrorin the data class. With this change they parse, and the missing headers come back asNone(or[]for the list headers in the data class).Verification
developand pass with this change. TheEventcase already passed.tests/unit/parserandtests/unit/data_classes/required_dependencies: 366 passed (Python 3.12).ruff check,ruff format --checkandmypyare clean on the changed files.invocationTypecomes from the captured event in the TypeScript issue.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.