Repository navigation
fix(data_classes): return None for the SQS attribute value an attribute does not carry - #8713
Conversation
…te does not carry
leandrodamascena
left a comment
There was a problem hiding this comment.
Thanks @anishmehta24, confirmed with a real event: I sent a message with String, Number and Binary attributes through a queue to a function and Lambda delivers only the field matching the type, so binary_value on the String one raises KeyError on develop and returns None with your change, same as the Pydantic model already does.
I'm approving now. This goes out in 3.40.0, so it will sit here for a while before I merge it. No rebase needed in the meantime, and you'll be credited in the release notes.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #8713 +/- ##
========================================
Coverage 97.02% 97.02%
========================================
Files 321 321
Lines 16443 16443
Branches 1487 1487
========================================
Hits 15954 15954
Misses 349 349
Partials 140 140 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|



Issue number: closes #8712
Summary
Changes
SQSMessageAttribute.string_valueandbinary_valueare typedstr | Nonebut indexed the dict directly. Lambda only includes the field matching the attribute's type (a String attribute has nobinaryValue, a Binary one nostringValue), so reading the other one raisedKeyError. Both now useself.get(...)and returnNone, which matches their type hints and the PydanticSqsMsgAttributeModel; the docstrings say when the value isNone.Added
test_sqs_message_attribute_with_only_one_valueintests/unit/data_classes/required_dependencies/test_sqs_event.pywith a String and a Binary attribute shaped like the Lambda docs example; it fails ondevelopwithKeyError: 'binaryValue'. The data classes and batch tests pass.User experience
Before:
record.message_attributes["text"].binary_valueon a String attribute raisesKeyError. After: it returnsNone.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.