Skip to content

fix(event_handler): leave SameSite out of cookies in DEFAULT_MODE - #8709

Merged
leandrodamascena merged 2 commits into
aws-powertools:developfrom
anishmehta24:fix/cookie-samesite-default-mode
Nov 4, 2026
Merged

leandrodamascena merged 2 commits into
aws-powertools:developfrom
anishmehta24:fix/cookie-samesite-default-mode

Conversation

@anishmehta24

Copy link
Copy Markdown
Contributor

Issue number: closes #8708

Summary

Changes

Cookie.__str__ wrote SameSite={value} for any same_site enum member, and SameSite.DEFAULT_MODE has the value "", so a cookie in default mode was sent with SameSite=. The attribute is now only written when the value is not empty, which leaves it out for DEFAULT_MODE like Go's http.SameSiteDefaultMode.

Added test_cookie_with_same_site_default_mode in tests/unit/test_cookie_class.py; it fails on develop. The cookie unit tests and the event handler cookie tests pass.

User experience

Before: str(Cookie("session", "abc", same_site=SameSite.DEFAULT_MODE)) is session=abc; Secure; SameSite=. After: session=abc; Secure.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@anishmehta24
anishmehta24 requested a review from a team as a code owner October 30, 2026 16:50
@anishmehta24
anishmehta24 requested a review from svozza October 30, 2026 16:50
@powertools-for-aws-oss-automation powertools-for-aws-oss-automation Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 30, 2026
@leandrodamascena leandrodamascena added this to the 3.40.0 milestone Oct 30, 2026

@leandrodamascena leandrodamascena left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @anishmehta24, confirmed through both the REST and HTTP API resolvers: DEFAULT_MODE now leaves SameSite out, Lax/Strict/None and cookies without same_site are unchanged.

I'm approving now. This goes out in 3.40.0, so it will sit here for a while before I merge it. No rebase needed in the meantime, and you'll be credited in the release notes.

@sonarqubecloud

sonarqubecloud Bot commented Nov 4, 2026

Copy link
Copy Markdown

@codecov

codecov Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.01%. Comparing base (9945fcb) to head (6f2bb15).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #8709   +/-   ##
========================================
  Coverage    97.01%   97.01%           
========================================
  Files          321      321           
  Lines        16432    16432           
  Branches      1484     1484           
========================================
  Hits         15941    15941           
  Misses         350      350           
  Partials       141      141           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@leandrodamascena
leandrodamascena merged commit 30ebaa4 into aws-powertools:develop Nov 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

commons size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Cookie with SameSite.DEFAULT_MODE sends an empty SameSite= attribute

2 participants