diff --git a/aws_lambda_powertools/utilities/idempotency/base.py b/aws_lambda_powertools/utilities/idempotency/base.py index 9c8d0d40fab..8cdc1a6fe09 100644 --- a/aws_lambda_powertools/utilities/idempotency/base.py +++ b/aws_lambda_powertools/utilities/idempotency/base.py @@ -271,7 +271,7 @@ def _handle_for_status(self, data_record: DataRecord) -> Any | None: raise IdempotencyAlreadyInProgressError(inprogress_error_message) response_dict = data_record.response_json_as_dict() - serialized_response = self.output_serializer.from_dict(response_dict) if response_dict else None + serialized_response = self.output_serializer.from_dict(response_dict) if response_dict is not None else None if self.config.response_hook: logger.debug("Response hook configured, invoking function") diff --git a/tests/functional/idempotency/_boto3/test_idempotency.py b/tests/functional/idempotency/_boto3/test_idempotency.py index fe70251905d..44b00b3c5d5 100644 --- a/tests/functional/idempotency/_boto3/test_idempotency.py +++ b/tests/functional/idempotency/_boto3/test_idempotency.py @@ -1398,6 +1398,36 @@ def record_handler(record): assert from_dict_called is False, "in case response is None, from_dict should not be called" +@pytest.mark.parametrize( + "expected_result", + [0, False, "", [], {}], + ids=["zero", "false", "empty_str", "empty_list", "empty_dict"], +) +def test_idempotent_function_falsy_response_replay(expected_result): + # GIVEN a function returning a falsy value + config = IdempotencyConfig(use_local_cache=True) + mock_event = {"customer_id": "fake", "transaction_id": "fake-id"} + idempotency_key = f"{TESTS_MODULE_PREFIX}.test_idempotent_function_falsy_response_replay..record_handler#{hash_idempotency_key(mock_event)}" # noqa E501 + persistence_layer = MockPersistenceLayer(expected_idempotency_key=idempotency_key) + calls = 0 + + @idempotent_function(persistence_store=persistence_layer, data_keyword_argument="record", config=config) + def record_handler(record): + nonlocal calls + calls += 1 + return expected_result + + # WHEN calling the function twice with the same payload + first_result = record_handler(record=mock_event) + second_result = record_handler(record=mock_event) + + # THEN the second call returns the stored falsy value instead of None + assert first_result == expected_result + assert second_result == expected_result + assert type(second_result) is type(expected_result) + assert calls == 1 + + @pytest.mark.parametrize("output_serializer_type", ["explicit", "deduced"]) def test_idempotent_function_serialization_dataclass(output_serializer_type: str): # GIVEN