Skip to content

chore(streaming): replace deprecated Version classes from distutils #2752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 12, 2023
Merged

chore(streaming): replace deprecated Version classes from distutils #2752

merged 2 commits into from
Jul 12, 2023

Conversation

leandrodamascena
Copy link
Contributor

Issue number: #2747

Summary

Changes

This pull request proposes the replacement of distutils library to resolve a deprecation warning in Python.

User experience

Customers will no longer receive the warning message:

DeprecationWarning: distutils Version classes are deprecated. Use packaging.version instead.

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@leandrodamascena leandrodamascena requested a review from a team July 12, 2023 13:37
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 12, 2023
@leandrodamascena leandrodamascena changed the title fix(streaming): replace deprecated Version function from distutils fix(streaming): replace deprecated Version classes from distutils Jul 12, 2023
@github-actions github-actions bot added the bug Something isn't working label Jul 12, 2023
@heitorlessa heitorlessa changed the title fix(streaming): replace deprecated Version classes from distutils chore(streaming): replace deprecated Version classes from distutils Jul 12, 2023
@github-actions github-actions bot added the internal Maintenance changes label Jul 12, 2023
Copy link
Contributor

@heitorlessa heitorlessa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NICE! typically this would be a somewhat expensive operation (string->int), but it's largely until Lambda upgrades the runtime SDK

@heitorlessa heitorlessa removed the bug Something isn't working label Jul 12, 2023
@heitorlessa heitorlessa merged commit d9dba96 into aws-powertools:develop Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Maintenance changes size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. streaming
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tech debt: Use packaging.version instead of deprecated Version classes from distutils
2 participants