SPICE-0024: Annotation converters
#1333
Open
+639
−71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HT154
force-pushed
the
annotation-converters
branch
from
f34bd77 to
1870188
Compare
HT154
force-pushed
the
annotation-converters
branch
from
1870188 to
274ba33
Compare
HT154
changed the title
Annotation-based convertersAnnotation converters
HT154
force-pushed
the
annotation-converters
branch
2 times, most recently
from
97ac0af to
df576b6
Compare
HT154
commented
Dec 22, 2025
Comment on lines
+23
to
+29
| import "pkl:json" | ||
| import "pkl:jsonnet" | ||
| import "pkl:math" | ||
| import "pkl:pklbinary" | ||
| import "pkl:protobuf" | ||
| import "pkl:xml" | ||
| import "pkl:yaml" |
Contributor
Author
There was a problem hiding this comment.
Note that these modules are unused by functional code, but are required to correctly resolve doc comment references.
HT154
force-pushed
the
annotation-converters
branch
from
df576b6 to
2d813fe
Compare
HT154
force-pushed
the
annotation-converters
branch
from
2d813fe to
192ed70
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been banging around in my head for a while and I finally needed to get it out.
This PR adds a new property
BaseValueRenderer#annotationConvertersthat enables defining converters that act on both the property name and value of annotated properties ofTypedvalues.This enables defining declarative key and/or value transformations in cases where neither
Class- nor path-based converters can be applied gracefully. It is also the only way to express transforming the resulting property names inTypedobjects without applying a converter to the entire containing type, which is cumbersome at best.This PR originally overloaded
BaseValueRenderer#convertersfor this purpose. This implementation has been preserved in the first commit in the PR if you wish to compare that to implementation with the new property. A limitation of the previous design is that you can't have both a class and annotation converter for the sameAnnotationsubclass (though this is probably unlikely to be an issue in practice).SPICE: apple/pkl-evolution#26
This also fixes a silly wart in the API for getting class property mirrors.
Resolves #576