-
-
Notifications
You must be signed in to change notification settings - Fork 957
feat(json-schema): mutualize json schema between formats #6960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
981e6e1 to
86c39da
Compare
5e66fd1 to
33dc6fa
Compare
dea48d6 to
7cc3f8c
Compare
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
6823232 to
5908915
Compare
note that the test in docs.feature has been moved to phpunit
c7f58bb to
ffd782d
Compare
bee49ae to
88ff9fb
Compare
e68a981 to
651e978
Compare
4f84825 to
e620f9b
Compare
|
@soyuka Thank you for the great job! |
|
@soyuka For HydraCollectionBaseSchema this seems problematic, as it defines a property "member" with a simple "object" type (no specific type specified) As order should not impact the schema, client generation libraries have no idea of which "member" definition to take Shouldn't we remove member definition from HydraCollectionBaseSchema ? and keep only the correct full typed one ? |
With - api-platform/core#6960 generating the nested write payload objects via the schema completely broke. The examples in the OpenApi Webui are still broken.
With - api-platform/core#6960 generating the nested write payload objects via the schema completely broke. The examples in the OpenApi Webui are still broken.
With - api-platform/core#6960 generating the nested write payload objects via the schema completely broke. The examples in the OpenApi Webui are still broken.
With - api-platform/core#6960 generating the nested write payload objects via the schema completely broke. The examples in the OpenApi Webui are still broken.
With - api-platform/core#6960 generating the nested write payload objects via the schema completely broke. The examples in the OpenApi Webui are still broken.
With - api-platform/core#6960 generating the nested write payload objects via the schema completely broke. The examples in the OpenApi Webui are still broken.
Instead of generating twice a definition for 2 different formats, we generate the
jsonone and reference thejsonformat inside thejsonldformat:https://gist.github.com/soyuka/20d0d216c3fce1b68165dbbf58381e02
When generating a single resource on our TestBundle we lower the OpenAPI file size quite a bit:
Left to be done: