[SYSTEMDS-3891] Add OOC Reshape Primitive - #2619
Open
jessicapriebe wants to merge 3 commits into
Open
jessicapriebe wants to merge 3 commits into
jessicapriebe wants to merge 3 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2619 +/- ##
============================================
+ Coverage 71.41% 71.78% +0.36%
- Complexity 50721 50747 +26
============================================
Files 1642 2079 +437
Lines 197165 222615 +25450
Branches 38306 38343 +37
============================================
+ Hits 140815 159809 +18994
- Misses 45279 51693 +6414
- Partials 11071 11113 +42
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Baunsgaard
reviewed
Sep 21, 2026
Baunsgaard
left a comment
Contributor
There was a problem hiding this comment.
Just because i was curious on the OOC operator i took a look. However, it was not super decipherable from the PR for me, so I thought I would leave some hints to clean it up and make it readable.
All just suggestions.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds an OOC reshape primitive that reshapes matrices out-of-core by splitting input blocks into slices and storing them in the cache-owned state table. Output blocks are rebuilt individually or as block rows/columns, depending on the reshape dimensions, and are enqueued as soon as they are completed.