Skip to content

[core] Optimize snapshots collect in ExpireSnapshots#7397

Merged
JingsongLi merged 1 commit intoapache:masterfrom
JingsongLi:optimize_expire_snapshot_get_snapshot
Mar 11, 2026
Merged

[core] Optimize snapshots collect in ExpireSnapshots#7397
JingsongLi merged 1 commit intoapache:masterfrom
JingsongLi:optimize_expire_snapshot_get_snapshot

Conversation

@JingsongLi
Copy link
Copy Markdown
Contributor

@JingsongLi JingsongLi commented Mar 11, 2026

Purpose

This PR optimizes the collection method of snapshots in ExpireSnapsImpl, replacing the logic of sequentially reading snapshots from multiple locations in the ExpireUntil method with a one-time concurrent collection of all required snapshots to Map<Long, Snapshot>, and then directly querying from Map to avoid duplicate file IO.

Tests

API and Format

Documentation

Generative AI tooling

Copy link
Copy Markdown
Contributor

@yuzelin yuzelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@JingsongLi JingsongLi merged commit 6772bcd into apache:master Mar 11, 2026
12 of 16 checks passed
wzhero1 pushed a commit to wzhero1/paimon that referenced this pull request Mar 12, 2026
wzhero1 pushed a commit to wzhero1/paimon that referenced this pull request Mar 12, 2026
wzhero1 pushed a commit to wzhero1/paimon that referenced this pull request Mar 12, 2026
wzhero1 pushed a commit to wzhero1/paimon that referenced this pull request Mar 19, 2026
wzhero1 pushed a commit to wzhero1/paimon that referenced this pull request Mar 30, 2026
…eTask subclasses

fix minor comments

move paimon-core logic to paimon-flink

[core][flink] fix changelogDecoupled missing bug in parall mode

[core][flink] keep LocalAction

[core][flink] add support for: Optimize snapshots collect in ExpireSnapshots (apache#7397)

[core][flink] fix comments

[core][flink] Support parallelism snapshot expire
wzhero1 pushed a commit to wzhero1/paimon that referenced this pull request Mar 31, 2026
…eTask subclasses

fix minor comments

move paimon-core logic to paimon-flink

[core][flink] fix changelogDecoupled missing bug in parall mode

[core][flink] keep LocalAction

[core][flink] add support for: Optimize snapshots collect in ExpireSnapshots (apache#7397)

[core][flink] fix comments

[core][flink] Support parallelism snapshot expire
wzhero1 pushed a commit to wzhero1/paimon that referenced this pull request Apr 1, 2026
…eTask subclasses

fix minor comments

move paimon-core logic to paimon-flink

[core][flink] fix changelogDecoupled missing bug in parall mode

[core][flink] keep LocalAction

[core][flink] add support for: Optimize snapshots collect in ExpireSnapshots (apache#7397)

[core][flink] fix comments

[core][flink] Support parallelism snapshot expire
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants