[core] Negative unix timestamp support#5710
Merged
JingsongLi merged 2 commits intoapache:masterfrom Jun 12, 2025
Merged
Conversation
Also adding some test coverage to utils classes while I'm here
Removes some duplicated and unneccsary tests
Contributor
Author
|
@JingsongLi Mind having a look at this at some point, not urgent but we've potentially got some existing streams with negative timestamps we'll need to sink in the next month or so :) |
JingsongLi
approved these changes
Jun 12, 2025
Contributor
JingsongLi
left a comment
JingsongLi
left a comment
There was a problem hiding this comment.
Thanks @tub , looks good to me!
yuzelin
pushed a commit
that referenced
this pull request
Jun 12, 2025
(cherry picked from commit 8062d6c)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #5706
Allows unix timestamps to be negative, representing dates before 1970.
Tests
Added paimon-common/src/test/java/org/apache/paimon/utils/BinaryStringUtilsTest.java and paimon-common/src/test/java/org/apache/paimon/utils/StringUtilsTest.java covering both this change and increasing coverage of the existing methods.
API and Format
This doesn't change the API other than allowing negative timestamp values.
Documentation
n/a - the docs don't currently say that unix timestamps should be positive.