Fix #13230: make 'install' and 'deploy' depend on 'verify' in the lifecycle DAG - #13231
Merged
gnodet merged 1 commit intoSep 24, 2026
Merged
Conversation
gnodet
force-pushed
the
fix/13230-install-deploy-depend-on-verify
branch
from
September 22, 2026 10:23
80575ff to
f3b13e6
Compare
…he concurrent lifecycle DAG In the phase tree introduced for Maven 4, INSTALL and DEPLOY declared a dependency on PACKAGE only, not on VERIFY. This caused the concurrent builder (-b concurrent) to skip the VERIFY phase (unit tests, integration tests) when running 'mvn install', since no explicit edge existed between INSTALL and VERIFY in the DAG. The sequential builder was unaffected only by accident: its phase flattening happened to preserve the order, but this was not a semantic guarantee. Fix: change INSTALL and DEPLOY to declare after(VERIFY) instead of after(PACKAGE). VERIFY already depends transitively on BUILD (and therefore PACKAGE), so the full build order is preserved. Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
gnodet
force-pushed
the
fix/13230-install-deploy-depend-on-verify
branch
from
September 22, 2026 14:28
f3b13e6 to
97d2c3e
Compare
gnodet
marked this pull request as ready for review
September 23, 2026 10:35
rmannibucau
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix #13230: make
installanddeploydepend onverifyin the concurrent lifecycle DAG.Root Cause
In the phase tree introduced for Maven 4,
INSTALLandDEPLOYdeclared a dependency onPACKAGEonly, not onVERIFY:This caused the concurrent builder (
-b concurrent) to silently skip theVERIFYphase when runningmvn install, because there was no declared edge betweenINSTALLandVERIFYin the DAG.The sequential builder was unaffected only by accident: its phase flattening happened to preserve the order, but this was not a semantic guarantee.
Fix
Change
INSTALLandDEPLOYto declareafter(VERIFY)instead ofafter(PACKAGE):VERIFYalready depends transitively onBUILD(and thereforePACKAGE), so the full build order is preserved. This is also semantically correct: an artifact should not be installed or deployed before it has been verified.Hermes Agent (Claude Sonnet 4.6) on behalf of Guillaume Nodet