Fix NPE in DefaultModelBuilder when POM resolved from repository (backport to 4.0.x) - #12285
Merged
Merged
Conversation
) Fix NullPointerException in readEffectiveModel() when inputModel has no local POM file (e.g. dependency POM resolved from a remote repository). The relative path resolution for parent POMs called inputModel.getPomFile().getParent() without checking for null, causing an NPE when plugins like cyclonedx-maven-plugin resolve dependency models. Add null guard for inputModel.getPomFile() and reorder the isBuildRequest() check for short-circuit efficiency. Fixes #11919
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #11922 to maven-4.0.x.
Fix NullPointerException in readEffectiveModel() when inputModel has no local POM file (e.g. dependency POM resolved from a remote repository).
Fixes #11919