Add XmlService classloader fallback for ServiceLoader discovery - #12237
Merged
Merged
Conversation
When the thread context classloader cannot see the XmlService
provider (e.g. in plugin classloaders), fall back to loading
via XmlService's own classloader. This prevents
IllegalStateException("No XmlService implementation found")
in environments where the TCCL is isolated.
Co-authored-by: Arturo Bernal <abernal@apache.org>
gnodet
added a commit
to arturobernalg/maven
that referenced
this pull request
Jun 4, 2026
- Remove XmlService classloader fallback (extracted to PR apache#12237) - Use MavenModelVersion to compute the minimum model version instead of hardcoding 4.0.0 as the fallback - Align namespace/schemaLocation format strings with TransformerSupport conventions Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
cstamas
approved these changes
Jun 12, 2026
Contributor
|
@gnodet Please assign appropriate label to PR according to the type of change. |
gnodet
added a commit
that referenced
this pull request
Jun 13, 2026
…1742) * Fix #11715: preserve 4.1.0 namespace/schema in help:effective-pom When generating the effective POM for a modelVersion 4.1.0 project, preserve the root <project> namespace and schemaLocation as 4.1.0 instead of falling back to 4.0.0. Add/keep coverage with MavenITgh11715EffectivePomNamespaceTest to verify the effective POM header contains: - xmlns http://maven.apache.org/POM/4.1.0 - schemaLocation .../maven-4.1.0.xsd * Extract XmlService classloader fix and use MavenModelVersion - Remove XmlService classloader fallback (extracted to PR #12237) - Use MavenModelVersion to compute the minimum model version instead of hardcoding 4.0.0 as the fallback - Align namespace/schemaLocation format strings with TransformerSupport conventions Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Remove super(versionRange) call — AbstractMavenIntegrationTestCase has no String constructor Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Use declared modelVersion for namespace, fall back to MavenModelVersion MavenModelVersion computes the minimum required version based on features, but help:effective-pom should preserve the version declared in the POM. Use model.getModelVersion() first and only fall back to MavenModelVersion when the version is not explicitly set. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Guillaume Nodet <gnodet@gmail.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
gnodet
added a commit
to gnodet/maven
that referenced
this pull request
Jun 13, 2026
…he#12237) * Add XmlService classloader fallback for ServiceLoader discovery When the thread context classloader cannot see the XmlService provider (e.g. in plugin classloaders), fall back to loading via XmlService's own classloader. This prevents IllegalStateException("No XmlService implementation found") in environments where the TCCL is isolated. Co-authored-by: Arturo Bernal <abernal@apache.org> * Use import instead of FQCN for Optional Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Arturo Bernal <abernal@apache.org> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
gnodet
added a commit
to gnodet/maven
that referenced
this pull request
Jun 13, 2026
…om (apache#11742) * Fix apache#11715: preserve 4.1.0 namespace/schema in help:effective-pom When generating the effective POM for a modelVersion 4.1.0 project, preserve the root <project> namespace and schemaLocation as 4.1.0 instead of falling back to 4.0.0. Add/keep coverage with MavenITgh11715EffectivePomNamespaceTest to verify the effective POM header contains: - xmlns http://maven.apache.org/POM/4.1.0 - schemaLocation .../maven-4.1.0.xsd * Extract XmlService classloader fix and use MavenModelVersion - Remove XmlService classloader fallback (extracted to PR apache#12237) - Use MavenModelVersion to compute the minimum model version instead of hardcoding 4.0.0 as the fallback - Align namespace/schemaLocation format strings with TransformerSupport conventions Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Remove super(versionRange) call — AbstractMavenIntegrationTestCase has no String constructor Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Use declared modelVersion for namespace, fall back to MavenModelVersion MavenModelVersion computes the minimum required version based on features, but help:effective-pom should preserve the version declared in the POM. Use model.getModelVersion() first and only fall back to MavenModelVersion when the version is not explicitly set. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Guillaume Nodet <gnodet@gmail.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
gnodet
added a commit
to gnodet/maven
that referenced
this pull request
Jun 13, 2026
…om (apache#11742) * Fix apache#11715: preserve 4.1.0 namespace/schema in help:effective-pom When generating the effective POM for a modelVersion 4.1.0 project, preserve the root <project> namespace and schemaLocation as 4.1.0 instead of falling back to 4.0.0. Add/keep coverage with MavenITgh11715EffectivePomNamespaceTest to verify the effective POM header contains: - xmlns http://maven.apache.org/POM/4.1.0 - schemaLocation .../maven-4.1.0.xsd * Extract XmlService classloader fix and use MavenModelVersion - Remove XmlService classloader fallback (extracted to PR apache#12237) - Use MavenModelVersion to compute the minimum model version instead of hardcoding 4.0.0 as the fallback - Align namespace/schemaLocation format strings with TransformerSupport conventions Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Remove super(versionRange) call — AbstractMavenIntegrationTestCase has no String constructor Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Use declared modelVersion for namespace, fall back to MavenModelVersion MavenModelVersion computes the minimum required version based on features, but help:effective-pom should preserve the version declared in the POM. Use model.getModelVersion() first and only fall back to MavenModelVersion when the version is not explicitly set. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Guillaume Nodet <gnodet@gmail.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
gnodet
added a commit
that referenced
this pull request
Jun 13, 2026
…2255) * Fix #11715: preserve 4.1.0 namespace/schema in help:effective-pom When generating the effective POM for a modelVersion 4.1.0 project, preserve the root <project> namespace and schemaLocation as 4.1.0 instead of falling back to 4.0.0. Add/keep coverage with MavenITgh11715EffectivePomNamespaceTest to verify the effective POM header contains: - xmlns http://maven.apache.org/POM/4.1.0 - schemaLocation .../maven-4.1.0.xsd * Extract XmlService classloader fix and use MavenModelVersion - Remove XmlService classloader fallback (extracted to PR #12237) - Use MavenModelVersion to compute the minimum model version instead of hardcoding 4.0.0 as the fallback - Align namespace/schemaLocation format strings with TransformerSupport conventions * Remove super(versionRange) call — AbstractMavenIntegrationTestCase has no String constructor * Use declared modelVersion for namespace, fall back to MavenModelVersion MavenModelVersion computes the minimum required version based on features, but help:effective-pom should preserve the version declared in the POM. Use model.getModelVersion() first and only fall back to MavenModelVersion when the version is not explicitly set. --------- Co-authored-by: Arturo Bernal <abernal@apache.org> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extracted from #11742 (by @arturobernalg) to keep the classloader fix separate from the namespace-preservation fix (#11715).
When the thread context classloader cannot see the
XmlServiceprovider (e.g. in isolated plugin classloaders), theServiceLoader.load(XmlService.class)call fails withIllegalStateException("No XmlService implementation found").This change:
XmlService.class.getClassLoader()first — this is the core realm classloader which always sees the providerXmlServicelives in the API module, and its classloader reliably sees theimpl/maven-xmlprovider through Maven's core realm. The TCCL may be a plugin classrealm or an isolated classloader that cannot.Test plan
XmlServiceLoadingTestverifies discovery works when TCCL is an emptyURLClassLoaderthat cannot see the providerClaude Code on behalf of Guillaume Nodet
Co-authored-by: Arturo Bernal abernal@apache.org