Skip to content

[maven-4.0.x] Fix #12087: add surefire and failsafe plugins to PluginUpgradeStrategy - #12100

Closed
gnodet wants to merge 3 commits into
maven-4.0.xfrom
backport-12089-to-4.0.x
Closed

gnodet wants to merge 3 commits into
maven-4.0.xfrom
backport-12089-to-4.0.x

Conversation

@gnodet

@gnodet gnodet commented May 19, 2026

Copy link
Copy Markdown
Contributor

Backport of #12089 to maven-4.0.x.

Fixes #12087: adds maven-surefire-plugin and maven-failsafe-plugin to the PluginUpgradeStrategy so mvnup handles their version upgrades for Maven 4 compatibility.

Note: This PR depends on #12082 (domtrip migration on 4.0.x).

Claude Code on behalf of Guillaume Nodet

gnodet and others added 3 commits May 18, 2026 18:04
Adds InheritedPluginDetectionTests and effective model warning test
from maven-4.0.x branch (834daf2), converted from JDOM2 to domtrip.
Also fixes log level for effective model analysis failures from debug
to warning to avoid silently swallowing errors.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Older versions of maven-surefire-plugin and maven-failsafe-plugin
(e.g. 3.1.2) are incompatible with Maven 4, failing with
IllegalStateException in MojoExecutionScopeModule. Add both plugins
with minimum version 3.5.2 so mvnup upgrades them automatically.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
gnodet added a commit that referenced this pull request May 19, 2026
@gnodet gnodet added this to the 4.0.0-rc-6 milestone May 19, 2026
@gnodet

gnodet commented May 19, 2026

Copy link
Copy Markdown
Contributor Author

Claude Code on behalf of Guillaume Nodet

Closing — branch conflicts after the domtrip migration (#12082). Reopening as a new PR with cherry-picked squash commit from merged master PR #12089.

@gnodet gnodet closed this May 19, 2026
@github-actions github-actions Bot removed this from the 4.0.0-rc-6 milestone May 19, 2026
@slachiewicz
slachiewicz deleted the backport-12089-to-4.0.x branch August 16, 2026 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants