Fix #12087: add surefire and failsafe plugins to PluginUpgradeStrategy - #12089
Merged
Merged
Conversation
Older versions of maven-surefire-plugin and maven-failsafe-plugin (e.g. 3.1.2) are incompatible with Maven 4, failing with IllegalStateException in MojoExecutionScopeModule. Add both plugins with minimum version 3.5.2 so mvnup upgrades them automatically. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
rmannibucau
approved these changes
May 19, 2026
Contributor
|
@gnodet Please assign appropriate label to PR according to the type of change. |
3 tasks
gnodet
added a commit
that referenced
this pull request
May 19, 2026
…UpgradeStrategy (#12109) * Fix #12087: add surefire and failsafe plugins to PluginUpgradeStrategy (#12089) Older versions of maven-surefire-plugin and maven-failsafe-plugin (e.g. 3.1.2) are incompatible with Maven 4, failing with IllegalStateException in MojoExecutionScopeModule. Add both plugins with minimum version 3.5.2 so mvnup upgrades them automatically. Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> * Fix test compilation: use domtrip API instead of JDOM in PluginUpgradeStrategyTest Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
maven-surefire-pluginandmaven-failsafe-pluginto thePluginUpgradeStrategywith minimum version 3.5.2 for Maven 4 compatibilityIllegalStateException: No instance of Project is bound to the mojo execution scopeunder Maven 4Test plan
PluginUpgradeStrategyTesttests pass (23 tests)Closes #12087
🤖 Generated with Claude Code
Claude Code on behalf of Guillaume Nodet