Switch mvnup to domtrip - #11432
Merged
Merged
Switch mvnup to domtrip#11432
Conversation
Bukama
approved these changes
Nov 17, 2025
Bukama
left a comment
Bukama
left a comment
Contributor
There was a problem hiding this comment.
Thank you for the improvement.
cstamas
approved these changes
Nov 18, 2025
Contributor
|
@gnodet Please assign appropriate label to PR according to the type of change. |
4 tasks
gnodet
added a commit
that referenced
this pull request
May 18, 2026
gnodet
added a commit
that referenced
this pull request
May 19, 2026
gnodet
added a commit
that referenced
this pull request
May 19, 2026
…master (#12082) * Switch mvnup to domtrip (#11432) * Port inherited plugin detection tests to domtrip API Adds InheritedPluginDetectionTests and effective model warning test from maven-4.0.x branch (834daf2), converted from JDOM2 to domtrip. Also fixes log level for effective model analysis failures from debug to warning to avoid silently swallowing errors. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR switches the
mvnuptool to use DomTrip instead of JDOM for better XML roundtrip, as JDOM, like all compliant XML parsers focuses on the infoset and not on preserving formatting.Relates to apache/maven-release#1381