Skip to content

Commit dfbd925

Browse files
aschemanclaude
andcommitted
Fix 'skin cannot be null' by declaring the fluido skin (beta-3 workaround)
The site 2.0.0 descriptor no longer defaults a skin, so maven-site-plugin 3.22.0 fails the site build with 'skin cannot be null', which currently blocks the whole repo's CI. This is really a Maven 4.0.0-beta-3 core issue: beta-3 doesn't resolve the parent site descriptor, so the skin declared in the Maven parent isn't inherited. Parent resolution works again on 4.0.0-rc-5+, where this <skin> becomes redundant. Declare it explicitly to unblock CI on beta-3; a comment in site.xml documents that it should be dropped once the build moves off beta-3. Addresses review feedback from @slawekjaranowski. See apache/maven-site-plugin#1286. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
1 parent 98470ba commit dfbd925

1 file changed

Lines changed: 13 additions & 0 deletions

File tree

src/site/site.xml

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,19 @@ under the License.
2121

2222
<site xmlns="http://maven.apache.org/SITE/2.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
2323
xsi:schemaLocation="http://maven.apache.org/SITE/2.0.0 https://maven.apache.org/xsd/site-2.0.0.xsd">
24+
<!--
25+
Workaround for Maven 4.0.0-beta-3, the version this plugin currently builds against:
26+
on beta-3 the parent site descriptor is not resolved, so the skin declared in the
27+
Maven parent is not inherited and maven-site-plugin fails with "skin cannot be null".
28+
Parent resolution works again on Maven 4.0.0-rc-5+, where this <skin> is redundant
29+
(the parent's skin is inherited). Re-check and drop this once the build moves off
30+
beta-3. See apache/maven-site-plugin#1286 for the cryptic-error part.
31+
-->
32+
<skin>
33+
<groupId>org.apache.maven.skins</groupId>
34+
<artifactId>maven-fluido-skin</artifactId>
35+
<version>2.1.0</version>
36+
</skin>
2437
<body>
2538
<menu name="Overview">
2639
<item name="Introduction" href="index.html"/>

0 commit comments

Comments
 (0)