Conversation
The verify script checked the full English warning text, so the IT failed under non-English locales. Check for a few stable keywords instead. Fixes apache#1055
There was a problem hiding this comment.
Pull request overview
Makes the mcompiler-120 integration test verification locale-agnostic by avoiding assertions that depend on English javac diagnostics, improving test portability across non-English environments.
Changes:
- Replaces the verbatim English diagnostic assertion in
src/it/mcompiler-120/verify.groovywith locale-independent keyword checks. - Retains existing guards for
Compilation failurepresence andinvalid flagabsence.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+27
to
+28
| assert content.contains( 'add(E)' ) | ||
| assert content.contains( 'List' ) // May be `List` or `java.util.List`. |
elharo
approved these changes
Jul 4, 2026
elharo
merged commit Jul 4, 2026
a45d823
into
apache:maven-compiler-plugin-3.x
89 of 90 checks passed
|
@elharo Please assign appropriate label to PR according to the type of change. |
elharo
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1055 - Make IT mcompiler-120 locale-agnostic
What: Replace the locale-dependent verbatim assertion in
src/it/mcompiler-120/verify.groovywith locale-independent keyword checks.Why: The IT asserts
unchecked call to add(E) as a member of the raw type, which is the English javac diagnostic. On non-English locales (e.g. German: "nicht geprüfter Aufruf von add(E) als Mitglied des Raw-Typs List") this assertion fails, making the IT pass only under English.How: Replace the full English message check with two keyword assertions (
add(E)andList) that appear in every locale because they are type/method tokens substituted into the localized template, not translated text. The existingCompilation failureandinvalid flagguards are retained. This mirrors the approach already applied to the same IT on master.No production code is changed. Only the IT verification script is touched.
Following this checklist to help us incorporate your
contribution quickly and easily:
Note that commits might be squashed by a maintainer on merge.
This may not always be possible but is a best-practice.
N/A. This is an IT-only fix with no runtime changes. The IT itself is the test.
mvn verifyto make sure basic checks pass.A more thorough check will be performed on your pull request automatically.
mvn -Prun-its verify).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
ICLA submitted to secretary@apache.org on June 22, 2026.