Remove redundant project.build.sourceEncoding from IT POMs - #349
Merged
gnodet merged 1 commit intoSep 25, 2026
Merged
Conversation
Maven 4 defaults project.build.sourceEncoding to UTF-8 (MNG-7763). Since maven-clean-plugin 4.x requires Maven 4, this property is redundant in all IT pom.xml files under src/it/. Remove the property line and, where it was the only entry, the entire <properties> block (14 files); in 2 files the block is retained as it contains other properties. Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
gnodet-bot
approved these changes
Sep 24, 2026
gnodet-bot
left a comment
gnodet-bot
left a comment
There was a problem hiding this comment.
All 16 IT POMs that carried project.build.sourceEncoding=UTF-8 are covered — zero remaining after this PR. The two files with additional properties (file-sets-absolute-paths/pom.xml, file-sets-relative-paths/child-b/pom.xml) correctly retain their <properties> block with only the sourceEncoding line removed. The MNG-7763 claim holds: the plugin requires Maven 4.0.0-rc-6 minimum, and Maven 4 defaults project.build.sourceEncoding to UTF-8. Pure noise removal — nothing left to fix.
This review was generated by an AI agent, Hermès on behalf of @gnodet.
slachiewicz
approved these changes
Sep 25, 2026
slawekjaranowski
approved these changes
Sep 25, 2026
|
@gnodet Please assign appropriate label to PR according to the type of change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the redundant
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>property from all ITpom.xmlfiles undersrc/it/.Rationale
Maven 4 defaults
project.build.sourceEncodingtoUTF-8(MNG-7763). Sincemaven-clean-plugin4.x requires Maven 4 as its minimum build version, declaring this property explicitly in IT POMs is redundant noise.Changes
<properties>block contained onlyproject.build.sourceEncoding— the entire block is removed.file-sets-absolute-paths/pom.xml,file-sets-relative-paths/child-b/pom.xml): the<properties>block contains other properties — only thesourceEncodingline is removed, the block is retained.Co-authored-by: Claude Sonnet 4.6 noreply@anthropic.com