Migrate source-release ITs from maven-verifier to maven-executor - #131
Merged
Merged
Conversation
maven-verifier is deprecated (apache/maven-verifier#186)
Embedding Maven 4.0.0-rc-6 in the test JVM hangs (apache/maven-executor#47); the previous Verifier forked on Maven 4 as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the deprecated
org.apache.maven.shared:maven-verifierdependency in thesource-releasemodule withorg.apache.maven.executor:maven-executor:1.0.0, adding a small sharedVerifiertest helper (org.apache.its.util.Verifier) that wrapsExecutorHelper/ExecutorRequestand reproduces the subset of the old API the 11 ITs use (run a build with a fixed goal list, assert an error-free log).Verified:
mvn -B verify -Prun-its -pl source-release -am(JDK 17) → 11 tests, 0 failures (same count as master).Maven runs forked, as the previous Verifier effectively did on Maven 4: embedding Maven 4.0.0-rc-6 inside the test JVM hangs (apache/maven-executor#47).