Conversation
github-actions
Bot
added
streams
tests
|
|
||
| // wipe out state store to trigger restore process on restart | ||
| streams.close(); | ||
| streams.close(CloseOptions.groupMembershipOperation(CloseOptions.GroupMembershipOperation.LEAVE_GROUP)); |
Contributor
There was a problem hiding this comment.
I think leave group is by default in new protocol and this test uses new protocol.
Would this be redundant in this case ?
Contributor
There was a problem hiding this comment.
This test covers both protocols, so explicitly setting LEAVE_GROUP seems totally fine to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some Kafka Streams integration tests closed and immediately restarted a Streams instance with the same application ID. With the default shutdown behavior, the consumer could remain in the group until
session.timeout.msexpired, causing unnecessary waiting before the next instance could start or continue the test scenario.This change explicitly uses
LEAVE_GROUPfor clean shutdown paths followed by state deletion, restoration, offset manipulation, or application restart. Final teardown paths remain unchanged when group membership removal is not required.Test time (JUnit XML execution time, excluding Gradle build and compilation):
LagFetchIntegrationTestRestoreIntegrationTestSelfManagedOffsetLifecycleIntegrationTestSlidingWindowedKStreamIntegrationTestTest-only change. No production code, public APIs, test inputs, or assertions are affected.
Reviewers: Murali Basani muralidhar.basani@aiven.io, Ken Huang s7133700@gmail.com