KAFKA-21136: fix pid lookup for native process - #23537
Open
gaurav-narula wants to merge 2 commits into
Open
gaurav-narula wants to merge 2 commits into
gaurav-narula wants to merge 2 commits into
Conversation
Modifies the pid lookup for native image process to use pgrep instead of relying on `java_pids` which uses `jcmd` and assumes a JVM.
github-actions
Bot
added
triage
| try: | ||
| kafka_mode = self.context.globals.get("kafka_mode", "") | ||
| if kafka_mode == "native": | ||
| return [int(pid) for pid in node.account.ssh_capture(f"pgrep {self.java_class_name()}", allow_fail=True)] |
Contributor
There was a problem hiding this comment.
Do we have any processes running in native mode to test/verify this, now that pgrep is being used to find the pid ?
Contributor
Author
There was a problem hiding this comment.
Thanks for your review Murali!
The native process' name is kafka.Kafka and that's what self.java_class_name() returns. You can verify the correctness of this change by running a system test in native mode like so:
_DUCKTAPE_OPTIONS="--globals '{\"kafka_mode\":\"native\"}'" TC_PATHS="tests/kafkatest/tests/client/compression_test.py" bash tests/docker/run_tests.sh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modifies the pid lookup for native image process to use pgrep instead of relying on
java_pidswhich usesjcmdand assumes a JVM.Reviewers: Murali Basani muralidhar.basani@aiven.io