Skip to content

Build: Bump AWS SDK to 2.54.17 and migrate to Apache HttpClient 5 - #18195

Merged
huaxingao merged 1 commit into
apache:mainfrom
ebyhr:ebi/dependabot/gradle/software.amazon.awssdk-bom-2.54.17
Sep 22, 2026
Merged

Build: Bump AWS SDK to 2.54.17 and migrate to Apache HttpClient 5#18195
huaxingao merged 1 commit into
apache:mainfrom
ebyhr:ebi/dependabot/gradle/software.amazon.awssdk-bom-2.54.17

Conversation

@ebyhr

@ebyhr ebyhr commented Sep 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

@ebyhr ebyhr mentioned this pull request Sep 21, 2026
Closed
@huaxingao

huaxingao commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

The change makes sense to me.

Two nits:

  1. Please mention the migration in the title. Something like "Build: Bump AWS SDK to 2.54.17 and migrate to Apache HttpClient 5".

  2. aws-bundle/LICENSE still says we bundle Commons Codec and Commons Logging (around lines 206 and 213). This PR drops both from the jar, so those two blocks should be removed.

Also worth a release note: Apache 5 uses different logger names, so org.apache.http.* logging configs will stop matching. http-client.type=apache still works, but it now builds Apache5HttpClient.

@ebyhr ebyhr changed the title Build: Bump software.amazon.awssdk:bom from 2.54.13 to 2.54.17 Build: Bump AWS SDK to 2.54.17 and migrate to Apache HttpClient 5 Sep 21, 2026
@ebyhr
ebyhr force-pushed the ebi/dependabot/gradle/software.amazon.awssdk-bom-2.54.17 branch from 5cae720 to 340ecf3 Compare September 21, 2026 23:12
@ebyhr

ebyhr commented Sep 21, 2026

Copy link
Copy Markdown
Member Author

@huaxingao Thanks for your review! Renamed the PR title and updated aws-bundle/LICENSE.

@huaxingao

huaxingao commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

docs/docs/aws.md still has two links to apache-client (around L34 and L701). Could you point those at apache5-client too?

@dependabot @ebyhr
Build: Bump software.amazon.awssdk:bom from 2.54.13 to 2.54.17
dcebc73 
Bumps software.amazon.awssdk:bom from 2.54.13 to 2.54.17.

---
updated-dependencies:
- dependency-name: software.amazon.awssdk:bom
  dependency-version: 2.54.17
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@ebyhr
ebyhr force-pushed the ebi/dependabot/gradle/software.amazon.awssdk-bom-2.54.17 branch from 340ecf3 to dcebc73 Compare September 22, 2026 05:09
huaxingao
huaxingao approved these changes Sep 22, 2026
View reviewed changes

@huaxingao huaxingao left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@huaxingao
huaxingao merged commit af4552f into apache:main Sep 22, 2026
46 checks passed
@huaxingao

huaxingao commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Thanks @ebyhr for the PR!

@kevinjqliu kevinjqliu mentioned this pull request Sep 23, 2026
Merged
@nssalian nssalian mentioned this pull request Sep 24, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@huaxingao huaxingao huaxingao approved these changes

Assignees

No one assigned

Labels

AWS build docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ebyhr @huaxingao