Skip to content

Conversation

@Pil0tXia
Copy link
Member

Fixes #4847

Motivation

Admin endpoints may need secure transmission.

Modifications

  • Refactor AdminServer to have its own independent configuration class.
  • Start AdminServer even if all three protocols are not enabled.
  • Fix NPE caused by AbstractRemotingServer shutdown() method calling the wrong method.
  • Add TLS support for AdminServer (Document: https://github.com/apache/eventmesh-site/pull/214/files)

Documentation

  • Does this pull request introduce a new feature? (yes)
  • If yes, how is the feature documented? (docs)

Copy link
Member

@mxsm mxsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pil0tXia Please fix ci error

@xwm1992
Copy link
Contributor

xwm1992 commented Apr 22, 2024

Please fix the pr code conflict problem, and by the way, why do you need to mention pr that supports tls v1.3? jdk8 should not support it, and it needs jdk11 to support it, right? @Pil0tXia

# Conflicts:
#	eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/boot/AbstractHTTPServer.java
#	eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/boot/EventMeshServer.java
@Pil0tXia
Copy link
Member Author

@xwm1992

I've added a "JDK/JRE 8 Compatibility" chapter in apache/eventmesh-site@5ccbf9b.

@Pil0tXia Pil0tXia requested a review from xwm1992 April 27, 2024 10:56
@Pil0tXia Pil0tXia added the need review The review work of this PR needs another reviewer/PMC's help label May 18, 2024
@Pil0tXia Pil0tXia added ready for review PR is waiting for reviewer's approval or opinion (used as a strong reminder) and removed need review The review work of this PR needs another reviewer/PMC's help labels May 23, 2024
@Pil0tXia
Copy link
Member Author

@pchengma Great

@Pil0tXia
Copy link
Member Author

Pil0tXia commented Jun 1, 2024

@xwm1992 PTAL~

@xwm1992 xwm1992 merged commit 6a158ad into apache:master Jun 2, 2024
@Pil0tXia Pil0tXia deleted the pil0txia/admin_4847 branch June 2, 2024 12:59
@xwm1992 xwm1992 added this to the 1.11.0 milestone Dec 18, 2024
xuhongjia pushed a commit to Deckers-Ohana/eventmesh that referenced this pull request Mar 13, 2025
…pache#4848)

* Move admin port to http configs

* Refactor AdminServer to own independent configuration

* Support TLS/SSL for AdminServer

* Add default configs

* Rename jks file to a shorter name

* Add one line of comment

* Fetch current version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready for review PR is waiting for reviewer's approval or opinion (used as a strong reminder)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] HTTPS/(m)TLSv1.3 support for HTTP Admin Server

4 participants