[ISSUE #4402] Refactor the retry module with HashedWheelTimer.#4505
Merged
xwm1992 merged 8 commits intoapache:masterfrom Oct 25, 2023
Merged
[ISSUE #4402] Refactor the retry module with HashedWheelTimer.#4505xwm1992 merged 8 commits intoapache:masterfrom
xwm1992 merged 8 commits intoapache:masterfrom
Conversation
pandaapo
reviewed
Oct 23, 2023
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/timer/HashedWheelTimer.java
Show resolved
Hide resolved
Contributor
|
Please fix the build error. |
Contributor
Author
CI error has been fixed. |
Pil0tXia
approved these changes
Oct 23, 2023
Member
|
LGTM |
pandaapo
reviewed
Oct 24, 2023
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/retry/Retryer.java
Show resolved
Hide resolved
pandaapo
reviewed
Oct 24, 2023
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/AbstractRetryer.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #4505 +/- ##
============================================
- Coverage 15.47% 15.34% -0.13%
- Complexity 1452 1454 +2
============================================
Files 691 694 +3
Lines 28106 28372 +266
Branches 2626 2685 +59
============================================
+ Hits 4349 4354 +5
- Misses 23312 23572 +260
- Partials 445 446 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Contributor
Author
|
@pandaapo Please review the new changes, thanks. |
pandaapo
approved these changes
Oct 24, 2023
Pil0tXia
approved these changes
Oct 24, 2023
xwm1992
approved these changes
Oct 25, 2023
xuhongjia
pushed a commit
to Deckers-Ohana/eventmesh
that referenced
this pull request
Mar 13, 2025
…pache#4505) * Add HashedWheelTimer. * Integrate HashedWheelTimer to AbstractRetryer. * Refactor Retryer, RetryContxt. * Remove DelayQueue dependency. * Add retry debug log. * Fix checkstyle. * Optimize Retry interface. * Remove init method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4402 .
Modifications