Skip to content

Conversation

@g0715158
Copy link
Contributor

@g0715158 g0715158 commented Jul 6, 2023

Fixes #4171.

Motivation
The connector does to support pulsar sink and source plugins

Modifications
The connector supports pulsar's sink and source plugins

Documentation
Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
If a feature is not applicable for documentation, explain why?
If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Merging #4186 (aa5fdd7) into master (c18ef05) will not change coverage.
Report is 6 commits behind head on master.
The diff coverage is n/a.

❗ Current head aa5fdd7 differs from pull request most recent head 1410015. Consider uploading reports for the commit 1410015 to get more accurate results

@@            Coverage Diff            @@
##             master    #4186   +/-   ##
=========================================
  Coverage     16.87%   16.87%           
  Complexity     1426     1426           
=========================================
  Files           593      593           
  Lines         26068    26068           
  Branches       2396     2396           
=========================================
  Hits           4398     4398           
  Misses        21229    21229           
  Partials        441      441           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@mxsm mxsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@g0715158 settings.gradle conflict needs to be resolved

…-support_pulsar_sink

� Conflicts:
�	settings.gradle
@g0715158
Copy link
Contributor Author

@g0715158 settings.gradle conflict needs to be resolved

@mxsm It's already resolved,thanks

Copy link
Member

@mxsm mxsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mxsm mxsm merged commit dd40227 into apache:master Aug 1, 2023
@pandaapo pandaapo added this to the 1.10 milestone Dec 5, 2023
xuhongjia pushed a commit to Deckers-Ohana/eventmesh that referenced this pull request Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] support pulsar connector plugins

4 participants