Skip to content

Remove unused config consoleproxy.cmd.port#12807

Open
sureshanaparti wants to merge 2 commits intoapache:4.22from
shapeblue:remove-unused-config-consoleproxy.cmd.port
Open

Remove unused config consoleproxy.cmd.port#12807
sureshanaparti wants to merge 2 commits intoapache:4.22from
shapeblue:remove-unused-config-consoleproxy.cmd.port

Conversation

@sureshanaparti
Copy link
Copy Markdown
Contributor

@sureshanaparti sureshanaparti commented Mar 13, 2026

Description

This PR removes unused config 'consoleproxy.cmd.port'.

The config 'consoleproxy.cmd.port' reference is removed in 4.11.1.0 here: #2562. Before 4.11.1.0, it is referenced but not used -

String value = configs.get(Config.ConsoleProxyCmdPort.key());
value = configs.get("consoleproxy.sslEnabled");

Fixes #11615

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@sureshanaparti
Copy link
Copy Markdown
Contributor Author

@blueorangutan package

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to remove the legacy/unused global setting consoleproxy.cmd.port as part of the 4.22.0.0 → 4.22.1.0 schema upgrade, to avoid exposing a misleading configuration option.

Changes:

  • Adds a DB migration step to delete consoleproxy.cmd.port from cloud.configuration.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.60%. Comparing base (7c3637a) to head (bc12ec5).

Additional details and impacted files
@@             Coverage Diff              @@
##              4.22   #12807       +/-   ##
============================================
+ Coverage     3.70%   17.60%   +13.90%     
- Complexity       0    15663    +15663     
============================================
  Files          448     5917     +5469     
  Lines        38041   531523   +493482     
  Branches      7038    64981    +57943     
============================================
+ Hits          1409    93571    +92162     
- Misses       36445   427397   +390952     
- Partials       187    10555    +10368     
Flag Coverage Δ
uitests 3.70% <ø> (ø)
unittests 18.67% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sureshanaparti
Copy link
Copy Markdown
Contributor Author

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17126

Copy link
Copy Markdown
Contributor

@sudo87 sudo87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@github-actions
Copy link
Copy Markdown

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

@sureshanaparti sureshanaparti force-pushed the remove-unused-config-consoleproxy.cmd.port branch from 8dbb5d0 to bc12ec5 Compare March 25, 2026 10:30
@sureshanaparti
Copy link
Copy Markdown
Contributor Author

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17241

Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm, will be hard to prove completeness, but at least some manual regression testing will be needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

consoleproxy.cmd.port configuration is unused (legacy/no-op)

5 participants