Merged
Conversation
DaanHoogland
reviewed
Jan 3, 2025
sureshanaparti
changed the title
Member
|
@Pearl1594 Changes looks good and the dependent PR is also merged. Can you resolve the conflicts? |
Contributor
Author
|
@vishesh92 - this would need 4.20.2 to be released. As the upstream fix isn't in 4.21. So I'll wait for the release to update the listApis file |
vishesh92
force-pushed
the
fix-vm-usage-history
branch
from
28c7fb8 to
4428802
Compare
vishesh92
approved these changes
Nov 28, 2025
Member
|
Tested again. It's working as expected after the changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #97
Depends on: apache/cloudstack#10152