Restructuring perp/vault fees#243
Merged
aalavandhan merged 30 commits intoethers-updatefrom Apr 18, 2025
Merged
Conversation
Member
aalavandhan
commented
Mar 8, 2025
- Perp's mint/burn fees are paid to the vault (by minting/transfering perp tokens)
- All fees collected during flash swaps go to the vault's balance. (before it was split between perp and the vault)
- Added owner defined drSoftBounds (similar to bill broker), which determine when flash swap fees transition from constant value to the linearly increasing fee (previously the kink point was dr=1.0).
Restructuring perp/vault fees
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
brandoniles
reviewed
Mar 12, 2025
Member
brandoniles
left a comment
There was a problem hiding this comment.
I think we're good here, but do we have everything needed for the frontend to be able to represent fee activity?
Suggestions Co-authored-by: Brandon Iles <brandon@fragments.org>
Co-authored-by: Brandon Iles <brandon@fragments.org>
Member
Author
The mint/redeem preview functions should compute the fees and adjust for it. The UI should pick that up I think .. |
Co-authored-by: Brandon Iles <brandon@fragments.org>
Co-authored-by: Brandon Iles <brandon@fragments.org>
Rebalancing updates
Pair operations
Removed rollover fees in favor of daily rebalance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.