Skip to content

Linear Regression on Pandas DataFrame using Sci-kit Learn - #40

Open
amit2rrr wants to merge 2 commits into
amit1rrr:masterfrom
amit2rrr:package-updates
Open

amit2rrr wants to merge 2 commits into
amit1rrr:masterfrom
amit2rrr:package-updates

Conversation

@amit2rrr

Copy link
Copy Markdown
Collaborator

No description provided.

@amit1rrr amit1rrr changed the title MAINT: remove pinned versions from requirements.txt Linear Regression on Pandas DataFrame using Sci-kit Learn Dec 5, 2018
@amit1rrr

Copy link
Copy Markdown
Owner

Testing conversation comment.

Comment thread requirements.txt
pillow==3.4.2
matplotlib==1.5.1
seaborn==0.7.0
numpy

@amit1rrr amit1rrr Dec 28, 2018 •

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test comment.
You can add the next version

 numpy==1.11.2

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

R1 - Let me see.

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

R2 - It's done.

Comment thread requirements.txt
pillow==3.4.2
matplotlib==1.5.1
seaborn==0.7.0
numpy

@amit1rrr amit1rrr Dec 28, 2018 •

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test comment - 2

@amit1rrr amit1rrr left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This review has 2 comments in it.

Comment thread requirements.txt Outdated
matplotlib==1.5.1
seaborn==0.7.0
numpy
pandas

@amit1rrr amit1rrr Dec 28, 2018 •

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's start a review.

Comment thread requirements.txt Outdated
matplotlib==1.5.1
seaborn==0.7.0
numpy
pandas

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment as part of review

@amit1rrr

Copy link
Copy Markdown
Owner

This is a plain conversation comment.

@amit1rrr amit1rrr left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a

@amit1rrr amit1rrr left a comment •

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

b

Reply via ReviewNB

@amit1rrr amit1rrr left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c

@amit1rrr amit1rrr left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

d

@amit1rrr amit1rrr left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is close to perfect! Please address the suggested inline change.

Comment thread requirements.txt
pillow==3.4.2
matplotlib==1.5.1
seaborn==0.7.0
numpy

@amit1rrr amit1rrr Dec 28, 2018 •

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add more information here, and fix this typo. Post from ReviewNB

@amit1rrr amit1rrr left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is close to perfect! Please address the suggested inline change.

Comment thread requirements.txt
pillow==3.4.2
matplotlib==1.5.1
seaborn==0.7.0
numpy

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add more information here, and fix this typo. Post from ReviewNB

@amit1rrr amit1rrr left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is close to perfect! Please address the suggested inline change.

Comment thread requirements.txt
pillow==3.4.2
matplotlib==1.5.1
seaborn==0.7.0
numpy

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add more information here, and fix this typo. Post from ReviewNB

@amit1rrr

amit1rrr commented Jan 2, 2019

Copy link
Copy Markdown
Owner

T1 - HTML in comment ReviewNB

Comment thread requirements.txt
pillow==3.4.2
matplotlib==1.5.1
seaborn==0.7.0
numpy

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

T2 - HTML in comment ReviewNB

@amit1rrr amit1rrr left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is close to perfect! Please address the suggested inline change.

Comment thread requirements.txt
@@ -1,11 +1,11 @@
numpy==1.11.1

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

T3-Please add more information here, and fix this typo. Post from ReviewNB

@amit1rrr amit1rrr left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is close to perfect! Please address the suggested inline change.

Comment thread requirements.txt
@amit1rrr

amit1rrr commented Jan 2, 2019

Copy link
Copy Markdown
Owner

Testing conversation comment.

Quoting conversation comment.

Comment thread requirements.txt
pandas==0.18.1
scipy==0.17.1
scikit-learn==0.17.1
scikit-image==0.12.3

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

T21-pre

@amit1rrr amit1rrr Jan 3, 2019 •

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment in ReviewNB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants