fix: improve Makefile color code compatibility across shells

[kahowell]

Use tput for color codes with fallback to ANSI escape sequences to ensure better portability across different terminals and shell environments.

[github-actions]

Claude Code Review

Summary

This PR improves Makefile color code compatibility by switching from hardcoded ANSI escape sequences to tput commands with fallback support. This is a portability improvement that ensures better compatibility across different terminal emulators and shell environments.

Overall Assessment: APPROVED - This is a well-executed improvement with no blocking issues.

---

Issues by Severity

Blocker Issues

None.

Critical Issues

None.

Major Issues

None.

Minor Issues

1. Potential Performance Impact (Very Minor)

• Location: Makefile:54-59
• Issue: Each color variable now invokes a shell command at Makefile parse time (6 shell spawns per parse)
• Impact: Negligible - only microseconds added
• Recommendation: No action needed

---

Positive Highlights

Excellent Portability Solution

• tput is the POSIX-compliant way to query terminal capabilities
• Fallback to printf ensures backward compatibility
• 2>/dev/null prevents errors in non-terminal environments

Follows Shell Best Practices

• Uses printf instead of echo (more portable)
• Proper quoting of escape sequences
• Clean fallback logic with ||

Maintains Existing Behavior

• All 6 color codes preserved
• No changes to usage throughout Makefile
• Fallback values match original ANSI codes

Clean Implementation

• Explanatory comment added
• Consistent pattern across all variables
• Fixed BUILD_FLAGS whitespace as bonus

---

Recommendations

Priority 1: Merge Without Changes

This PR is ready to merge as-is. No blocking issues identified.

Priority 2: Future Enhancements (Separate Work)

1. Standardize bash scripts to use same tput pattern
2. Document pattern in coding standards
3. Consider shared scripts/lib/colors.sh library

---

Compliance with Standards

• CLAUDE.md: N/A (Makefile, not Go/TypeScript)
• Git Workflow: Feature branch, conventional commits
• Security: No issues
• Over-Engineering: No - focused change
• Documentation: Self-documenting

---

Conclusion

High-quality, focused improvement. Ready to merge.

Recommendation: MERGE

---

🔍 View AI decision process (logs available for 90 days)

📋 View memory system files loaded (click to expand)

What Amber Loaded for Code Review

Amber automatically loaded these repository standards from the memory system:

1. CLAUDE.md - Master project instructions, development standards
2. backend-development.md - Go backend, K8s integration patterns
3. frontend-development.md - NextJS, Shadcn UI, React Query patterns
4. security-standards.md - Auth, RBAC, token handling
5. k8s-client-usage.md - User token vs service account patterns
6. error-handling.md - Consistent error patterns
7. react-query-usage.md - Data fetching patterns

Impact: This review used your repository's specific code quality standards, security patterns, and best practices from the memory system (PRs #359, #360) - not just generic code review guidelines.