Update the comment about the --once in Constants.cs#1360
Merged
TingluoHuang merged 3 commits intomainfrom Sep 21, 2021
Merged
Conversation
thboop
previously approved these changes
Sep 21, 2021
Collaborator
thboop
left a comment
thboop
left a comment
There was a problem hiding this comment.
LGTM, should we remove the error when trying to register a --once runner
Member
Author
|
I think we should give a special warning about |
thboop
reviewed
Sep 21, 2021
Co-authored-by: Thomas Boop <52323235+thboop@users.noreply.github.com>
fhammerl
added a commit
that referenced
this pull request
Sep 30, 2021
* Update telemetry (#1355) * Track "pause-logging" * Bump release version * Don't retry 422 (#1352) * Update the comment about the `--once` in Constants.cs (#1360) * Update Constants.cs * feedback. * Update src/Runner.Listener/Runner.cs Co-authored-by: Thomas Boop <52323235+thboop@users.noreply.github.com> Co-authored-by: Thomas Boop <52323235+thboop@users.noreply.github.com> * Fix unconfiguring of runner after group changes (#1359) * Ignore agentpool when unconfiguring the runner Runner names and IDs are unique within a ServiceHost They don't need to be included when unconfiguring the runner. * Use -1 instead of 0 to highlight how it is ignored * Use overloads and 0 instead of -1 Using 0 seems to be the convention * Fix typo calling the wrong method * only cleanup runner local files on success (#1384) * Stop-Commands: stopToken restrictions (#1371) * Prevent stopTokens that are workflow commands Co-authored-by: Thomas Boop <52323235+thboop@users.noreply.github.com> * Check context for env var too * Accept true, 1 and $true instead of just "true" * Setup ExpressionValues in tests * Update src/Runner.Common/Constants.cs Co-authored-by: Thomas Boop <52323235+thboop@users.noreply.github.com> * Separate success and fail tests for invalid token * Fix envcontext for tests Co-authored-by: Thomas Boop <52323235+thboop@users.noreply.github.com> * Handle keeping previous OSX versions more smoothly on Mac (#1381) * Handle macOS upgrade smoothly * cleanup * misc cleanup * final updates * Update src/Misc/layoutbin/update.sh.template Co-authored-by: Patrick Ellis <319655+pje@users.noreply.github.com> * Update src/Misc/layoutbin/update.sh.template Co-authored-by: Patrick Ellis <319655+pje@users.noreply.github.com> * Upload telemetry and default to old method as needed * minor fix * add one more bit of logging * some more telemetry * quote variables to handle spaces * tiny fix for ubuntu * remove version and move telemetry to diag * use full path Co-authored-by: Patrick Ellis <319655+pje@users.noreply.github.com> * Runner 2.283.2 Release (#1389) Co-authored-by: Thomas Boop <52323235+thboop@users.noreply.github.com> Co-authored-by: Tingluo Huang <tingluohuang@github.com> Co-authored-by: Patrick Ellis <319655+pje@users.noreply.github.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have no plan to deprecate
--onceat this point.Updated message:
