Conversation
mumoshu
approved these changes
Aug 11, 2021
Collaborator
mumoshu
left a comment
mumoshu
left a comment
There was a problem hiding this comment.
LGTM. Thanks for fixing it!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub a while ago changed how secrets work, secrets are not accessible from forks now (also impacts dependabot). The docker username isn't a secret so I've just statically set it.
Additionally we had the runner version out of sync between latest and our immutable tags. I've moved all of the env stuff to the workflow level so we use the same runner software, docker version and username for both builds as they shouldn't ever be out of sync