Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for merging the last PR!
I was away on the weekend, so I apologize for the late response.
As promised, here is the PR addressing issues #8 and #9, making modifications to the CMake code.
With this PR, the configure step will
EIGEN_VERSIONvariable, here set to 3.3INTERFACE_INCLUDE_DIRECTORIESon thebytetracktargetThis makes it significantly easier to use ByteTrack from other CMake projects (as is my use case).
Side note
In the mean time, I have been making more drastic changes to the main code, since it looks like I will be using this library quite intensively.
Namely I have
clang-formatand committed that configuration fileByteTrack::updatemethod for (what I think is) better readabilitynewanddeletefor thelapjvinvocation and replaced it withstd::vectorObjectclass, integrating it into theSTrackclassconst int&or other constant primitive references, as these have no benefitas well as some other minor changes.
None of those changes are in this PR, but if you are interested I could make additional PRs.