Avoid creating functions at jump table entries in shared cache#8002
Open
Avoid creating functions at jump table entries in shared cache#8002
Conversation
…on tables Add a heuristic to skip creating functions at addresses that appear to be jump table entries rather than actual function starts. On aarch64, any entry that disassembles as a `udf` instruction is skipped, since `udf` is used as padding/data in jump tables and is not a valid function prologue. Fix #7992
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sub_functions.HeuristicIsAFunctioncheck before callingAddFunctionForAnalysis. On aarch64, if the first instruction at the candidate address disassembles asudf, the entry is skipped —udfis used as padding/data in jump tables and is never a valid function prologue.Fix #7992