chore: run `apt-get update` before running other commands #41

Panquesito7 · 2023-06-23T20:16:35Z

Things added/changed:

Run sudo apt-get update before running other commands on the Gitpod Dockerfile.

This will run `sudo apt-get update` before running any other commands on the Gitpod prebuild image (`.gitpod.dockerfile`).

dlesnoff · 2023-06-23T20:21:42Z

Isn't an apt-get upgrade necessary after an update?

Panquesito7 · 2023-06-23T20:24:47Z

Isn't an apt-get upgrade necessary after an update?

Sometimes, not all of the packages are updated, even on the first start, AFAIK.

dlesnoff

Looks good to me.

vil02 · 2023-06-23T22:19:20Z

@Panquesito7 I know that this was already merged, but I would like to know why do you think this change is needed? Is it recommended to run sudo apt-get update before executing the https://nim-lang.org/choosenim/init.sh script?

dlesnoff · 2023-06-23T22:26:00Z

curl might not be up to date.

vil02 · 2023-06-23T22:38:15Z

sudo apt-get update only updates the package index. In this case sudo apt-get upgrade is needed.

A side remark: in my opinion having a not updated curl is a smaller problem than using sudo in a docker file.

dlesnoff · 2023-06-23T22:57:33Z

I will check Docker's security recommendations tomorrow.

vil02 · 2023-06-24T09:40:32Z

After thinking about it, I have a strong opinion: this change should be reverted. The reasons are as follows:

apt-get update updates the index (and this is not needed in this case),
adding upgrade in order to update installed packages like curl does not make sense: this should be done inside the image gitpod/workspace-base.

@dlesnoff @Panquesito7 if you agree with me, I will make a suitable PR.

dlesnoff · 2023-06-24T10:47:17Z

I revert it, and I wait for a better suggestion.
EDIT: It opens another PR which I do not want.
I let you open another PR and we discuss that there.

This reverts commit 2cb579e.

…hms#41) This will run `sudo apt-get update` before running any other commands on the Gitpod prebuild image (`.gitpod.dockerfile`).

* Add a .github action to build DIRECTORY.md * Update gh action build_directory_md * Add ignored paths and git credentials * chore: minor Gitpod improvements (#34) Add Gitpod badge and prebuilds for all branches and forks * Add binary search (#37) * Add binary search * Update binary search: add recursive version * Update binary search: better description * Update binary search: update runnableExamples * Update binary search: improve tests, add overload for recursive func * Update binary search: evaluate if-expression into result * grammar * Update binary search: improve description, add comments * Update binary search: add missing test cases * Update binary search: add info about pivot choice in description, rearrange it * Update binary search: change int to Natural * Update binary search: if block -> guard clause * Update binary search: test cases * Update binary search: simplify docs * Update binary search: nimpretty * Apply suggestions from code review Co-authored-by: David Leal <halfpacho@gmail.com> * Replace by an attempt of github pr create * Fix branching and environment variable in the PR Co-authored-by: David Leal <halfpacho@gmail.com> * Create and populate the Maths directory (#4) * Add a sample of maths basic algorithms * Update maths/abs.nim Co-authored-by: Zoom <ZoomRmc@users.noreply.github.com> * Use openArray in absMaxSort Co-authored-by: Zoom <ZoomRmc@users.noreply.github.com> * Fix seq->openArray and int->SomeInteger * Use Positive as input instead * Update maths/addition_without_arithmetic.nim Co-authored-by: Pietro Peterlongo <pietro.peterlongo@gmail.com> * Name allocation number * [maths/abs] Replace maxAbsSort by signed[Min/Max]Abs * [Aliquot Sum] Add header * Add empty line at end of file * Remove Allocation number since it is a non standard algorithm * Fix titles * Run nimpretty on the files * Rename file and add DIRECTORY.md --------- Co-authored-by: Dimitri LESNOFF <dimitri.lesnoff@lip6.fr> Co-authored-by: David Leal <halfpacho@gmail.com> * Add arc length (#10) * Fix linear search (#33) * Use a dynamic allocated array (sequence) for strings * Run nimpretty * Add requested changes * Fix documentation generation * Fix test title according to changes Co-authored-by: Satin Wuker <74630829+SatinWuker@users.noreply.github.com> * Update comments to warn about indexing issues Modified a bit the suggestions of comments. Please check them before approving. Co-authored-by: Zoom <ZoomRmc@users.noreply.github.com> --------- Co-authored-by: Dimitri LESNOFF <dimitri.lesnoff@lip6.fr> Co-authored-by: Zoom <ZoomRmc@users.noreply.github.com> * chore: run `apt-get update` before running other commands (#41) This will run `sudo apt-get update` before running any other commands on the Gitpod prebuild image (`.gitpod.dockerfile`). * Readme: fix gitter link, add Nim logo, formatting fixes (#42) * Update README.md Use more extended markdown syntax instead of HTML, Add Matrix links Superseed PR #40 * Actually fix gitter! Move img src links to footer. Also changed the TheAlgorithms logo image link. * Restore TheAlgorithms logo link * More link fixes --------- Co-authored-by: dlesnoff <54949944+dlesnoff@users.noreply.github.com> * fix: nimpretty for `arc_length.nim` (#43) * chore: `gc`->`mm`, move back to `config.nims` (#47) * chore: revert #41 (#45) * Update codeowners * Fix: CONTRIBUTING.md links (#49) Uppercase `directory.md` to `DIRECTORY.md` * feat: add Levenshtein distance (#46) * feat: add Levenshtein distance * Apply suggestions from code review Co-authored-by: Zoom <ZoomRmc@users.noreply.github.com> * refactor: use toKey in initSubsolutions * style: use .Natural * style: remove blank line * refactor: add Key type * style: use descriptive variable names * style: use a, b instead of strA, strB * docs: add note about complexity * refator: add name to TestCase * docs: remove sentence about dp * docs: update documentation of `levenshteinDistance` Co-authored-by: Zoom <ZoomRmc@users.noreply.github.com> * docs: rename initLevenshteinDistanceMatrix and add its documentation * refactor: add fillLevenshteinDistanceMatrix * tests: reorganise tests, remove TestCase type * docs: add edit distance to module-level documentation * docs: mention Wagner–Fischer algorithm * docs: add comment in fillLevenshteinDistanceMatrix * style: reformat fillLevenshteinDistanceMatrix * docs: update DIRECTORY.md --------- Co-authored-by: Zoom <ZoomRmc@users.noreply.github.com> * docs: add missing `#` (#50) * docs: add missing `#` * docs: update DIRECTORY.md * docs: remove ` of a Circle` * docs: update DIRECTORY.md --------- Co-authored-by: dlesnoff <54949944+dlesnoff@users.noreply.github.com> * Fix: Remove unuseful date command * chore: Update checkout version to v4 in build_directory_md * Add error status checking + separate compilation and execution of directory.nim --------- Co-authored-by: Dimitri LESNOFF <dimitri.lesnoff@lip6.fr> Co-authored-by: David Leal <halfpacho@gmail.com>

chore: run apt-get update before running other commands

3d7b676

This will run `sudo apt-get update` before running any other commands on the Gitpod prebuild image (`.gitpod.dockerfile`).

Panquesito7 added the enhancement New feature or request label Jun 23, 2023

Panquesito7 requested a review from dlesnoff as a code owner June 23, 2023 20:16

dlesnoff approved these changes Jun 23, 2023

View reviewed changes

dlesnoff merged commit 2cb579e into main Jun 23, 2023

Panquesito7 deleted the apt_update branch June 23, 2023 20:45

dlesnoff added a commit that referenced this pull request Jun 24, 2023

Revert "chore: run apt-get update before running other commands (#41)"

9835401

This reverts commit 2cb579e.

dlesnoff mentioned this pull request Jun 24, 2023

Revert "chore: run apt-get update before running other commands" #44

Closed

vil02 added a commit to vil02/Nim that referenced this pull request Jun 24, 2023

chore: revert TheAlgorithms#41

45156ef

vil02 mentioned this pull request Jun 24, 2023

chore: revert #41 #45

Merged

dlesnoff pushed a commit that referenced this pull request Jun 27, 2023

chore: revert #41 (#45)

712ce48

dlesnoff pushed a commit to SatinWukerORIG/Nim that referenced this pull request Jun 27, 2023

chore: revert TheAlgorithms#41 (TheAlgorithms#45)

8e61829

dlesnoff pushed a commit to dlesnoff/Nim-Algorithms that referenced this pull request Jul 4, 2023

chore: revert TheAlgorithms#41 (TheAlgorithms#45)

7dc52f7

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore: run `apt-get update` before running other commands #41

chore: run `apt-get update` before running other commands #41

Uh oh!

Panquesito7 commented Jun 23, 2023

Uh oh!

dlesnoff commented Jun 23, 2023

Uh oh!

Panquesito7 commented Jun 23, 2023

Uh oh!

dlesnoff left a comment

Uh oh!

vil02 commented Jun 23, 2023

Uh oh!

dlesnoff commented Jun 23, 2023

Uh oh!

vil02 commented Jun 23, 2023 •

edited

Loading

Uh oh!

dlesnoff commented Jun 23, 2023

Uh oh!

vil02 commented Jun 24, 2023

Uh oh!

dlesnoff commented Jun 24, 2023 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

chore: run apt-get update before running other commands #41

chore: run apt-get update before running other commands #41

Uh oh!

Conversation

Panquesito7 commented Jun 23, 2023

Uh oh!

dlesnoff commented Jun 23, 2023

Uh oh!

Panquesito7 commented Jun 23, 2023

Uh oh!

dlesnoff left a comment

Choose a reason for hiding this comment

Uh oh!

vil02 commented Jun 23, 2023

Uh oh!

dlesnoff commented Jun 23, 2023

Uh oh!

vil02 commented Jun 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dlesnoff commented Jun 23, 2023

Uh oh!

vil02 commented Jun 24, 2023

Uh oh!

dlesnoff commented Jun 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

chore: run `apt-get update` before running other commands #41

chore: run `apt-get update` before running other commands #41

vil02 commented Jun 23, 2023 •

edited

Loading

dlesnoff commented Jun 24, 2023 •

edited

Loading