Implement Gale-Shapley stable matching #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an adaptation of my much earlier implementation made for the RosettaCode project. The additional requirements of the task were moved to the runnableExamples block. The code was updated, thoroughly checked and commented. The name for the category is similar to one used for earlier C# and Lua implementations.
ZoomRmc
commented
Jun 23, 2023
dlesnoff
reviewed
Jun 29, 2023
Collaborator
dlesnoff
left a comment
dlesnoff
left a comment
There was a problem hiding this comment.
Not a great review, but I think that the implementation is quite fine!
I will make another pass in a few days.
dlesnoff
reviewed
Jun 29, 2023
dlesnoff
added a commit
to dlesnoff/Nim-Algorithms
that referenced
this pull request
Jul 4, 2023
* Implement Gale-Shapley stable matching This is an adaptation of my much earlier implementation made for the RosettaCode project. The additional requirements of the task were moved to the runnableExamples block. The code was updated, thoroughly checked and commented. The name for the category is similar to one used for earlier C# and Lua implementations. * Add more docs; `Clash` made numerical * Remove repetition in module's RE block --------- Co-authored-by: dlesnoff <54949944+dlesnoff@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an adaptation of my much earlier implementation made for the RosettaCode project. The additional requirements of the task were moved to the runnableExamples block.
The code was updated, thoroughly checked and commented.
The name for the category is similar to one used for earlier C# and Lua implementations.