-
Notifications
You must be signed in to change notification settings - Fork 89
Support aar dependency #65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Support aar dependency #65
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances FFmpeg integration by switching from APK-synthetics to view binding, adding Android 14+ media pickers, updating dependency configurations, and refining AAR support.
- Migrated all activities to use ViewBinding and modern ActivityResult APIs with fallbacks for older Android versions
- Updated build infrastructure: Gradle wrapper to 8.5, compileSdk to 35, Java compatibility to 1.8, and JDK targets in JitPack
- Improved AAR dependency handling in SSffmpegVideoOperation (flatDir inclusion, README integration guide,
Common.getFilePathadjustments)
Reviewed Changes
Copilot reviewed 44 out of 46 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| jitpack.yml | Added OpenJDK 8 support for JitPack builds |
| gradle/wrapper/gradle-wrapper.properties | Upgraded Gradle distribution to 8.5 |
| gradle.properties | Suppressed unsupported compileSdk warnings |
| AndroidManifest.xml | Adjusted READ_EXTERNAL_STORAGE maxSdkVersion |
| app/build.gradle | Updated SDK versions, Java compatibility, viewBinding |
| SSffmpegVideoOperation/build.gradle | Configured flatDir for mobile-ffmpeg.aar |
| SSffmpegVideoOperation/src/.../Common.kt | Expanded public file paths for Android 14+ |
| SSffmpegVideoOperation/src/.../FFmpegQueryExtension.kt | Ensured even video dimensions |
| README.md | Detailed JitPack & local AAR integration instructions |
Comments suppressed due to low confidence (1)
app/src/main/res/values/strings.xml:114
- XML resource files do not support '//' comments. Replace this line with a proper XML comment () or remove it to avoid resource compilation errors.
// Time Picker
app/src/main/java/com/simform/videoimageeditor/videoProcessActivity/CombineImagesActivity.kt
Outdated
Show resolved
Hide resolved
371061e to
fe7b15e
Compare
fe7b15e to
ea7b52d
Compare
ea7b52d to
6165294
Compare
I currently have an app in production that uses this library. I downloaded your fork's mobile-fmpeg.aar and implemented your library in my project. Google just added a new requirement for native code to support 16kb memory sizes. Unfortunately, your mobile-fmpeg.aar does not meet Google Play's 16 KB page size requirements. Can you include a mobile-ffmpeg aar that is built with 16kb memory size in your fork? Thank you! |
This pull request introduces significant updates to the FFmpeg integration library and its sample app. The changes focus on improving integration options and updating dependencies.
Integration Improvements
README.mdto provide detailed integration instructions, including JitPack and local setup options, permissions, and ProGuard configuration. Added troubleshooting steps for common issues. [1] [2].gitignoreto ensure themobile-ffmpeg.aarfile is included in the repository.