Skip to content

Conversation

@Rajan-p-simform
Copy link

This pull request introduces significant updates to the FFmpeg integration library and its sample app. The changes focus on improving integration options and updating dependencies.

Integration Improvements

  • Updated README.md to provide detailed integration instructions, including JitPack and local setup options, permissions, and ProGuard configuration. Added troubleshooting steps for common issues. [1] [2]
  • Modified .gitignore to ensure the mobile-ffmpeg.aar file is included in the repository.

@Rajan-p-simform Rajan-p-simform requested a review from Copilot July 7, 2025 06:24
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances FFmpeg integration by switching from APK-synthetics to view binding, adding Android 14+ media pickers, updating dependency configurations, and refining AAR support.

  • Migrated all activities to use ViewBinding and modern ActivityResult APIs with fallbacks for older Android versions
  • Updated build infrastructure: Gradle wrapper to 8.5, compileSdk to 35, Java compatibility to 1.8, and JDK targets in JitPack
  • Improved AAR dependency handling in SSffmpegVideoOperation (flatDir inclusion, README integration guide, Common.getFilePath adjustments)

Reviewed Changes

Copilot reviewed 44 out of 46 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
jitpack.yml Added OpenJDK 8 support for JitPack builds
gradle/wrapper/gradle-wrapper.properties Upgraded Gradle distribution to 8.5
gradle.properties Suppressed unsupported compileSdk warnings
AndroidManifest.xml Adjusted READ_EXTERNAL_STORAGE maxSdkVersion
app/build.gradle Updated SDK versions, Java compatibility, viewBinding
SSffmpegVideoOperation/build.gradle Configured flatDir for mobile-ffmpeg.aar
SSffmpegVideoOperation/src/.../Common.kt Expanded public file paths for Android 14+
SSffmpegVideoOperation/src/.../FFmpegQueryExtension.kt Ensured even video dimensions
README.md Detailed JitPack & local AAR integration instructions
Comments suppressed due to low confidence (1)

app/src/main/res/values/strings.xml:114

  • XML resource files do not support '//' comments. Replace this line with a proper XML comment () or remove it to avoid resource compilation errors.
    // Time Picker

@Rajan-p-simform Rajan-p-simform force-pushed the feature/support-aar-dependency branch from 371061e to fe7b15e Compare July 7, 2025 13:29
@Rajan-p-simform Rajan-p-simform force-pushed the feature/support-aar-dependency branch from fe7b15e to ea7b52d Compare July 9, 2025 14:31
@Rajan-p-simform Rajan-p-simform force-pushed the feature/support-aar-dependency branch from ea7b52d to 6165294 Compare July 14, 2025 12:35
@kunaljaypatel
Copy link

kunaljaypatel commented Aug 29, 2025

This pull request introduces significant updates to the FFmpeg integration library and its sample app. The changes focus on improving integration options and updating dependencies.

Integration Improvements

  • Updated README.md to provide detailed integration instructions, including JitPack and local setup options, permissions, and ProGuard configuration. Added troubleshooting steps for common issues. [1] [2]
  • Modified .gitignore to ensure the mobile-ffmpeg.aar file is included in the repository.

I currently have an app in production that uses this library.

I downloaded your fork's mobile-fmpeg.aar and implemented your library in my project. Google just added a new requirement for native code to support 16kb memory sizes.

Unfortunately, your mobile-fmpeg.aar does not meet Google Play's 16 KB page size requirements. Can you include a mobile-ffmpeg aar that is built with 16kb memory size in your fork?

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants