Conversation
… and docs - Split link-check into blocking relative (offline, fail: true) and advisory external jobs - Remove dead evidence placeholder links from GHOST_IN_THE_MACHINE.md submission template - Addresses rustchain-bounties#16248 acceptance: relative links must fail CI when broken Closes Scottcjn#7910 Closes Scottcjn#7908 Closes Scottcjn#7886 Closes Scottcjn#7885 Closes Scottcjn#7792
Contributor
|
Welcome to RustChain! Thanks for your first pull request. Before we review, please make sure:
Bounty tiers: Micro (1-10 RTC) | Standard (20-50) | Major (75-100) | Critical (100-150) A maintainer will review your PR soon. Thanks for contributing! |
github-actions
Bot
added
documentation
3 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves rustchain-bounties#16248 (5 RTC, claimed by @Ljunqiang).
What this changes
.github/workflows/lychee.yml— split into two jobs:linkcheck-relative(blocking):lychee --offlineoverREADME.md, top-level*.md, anddocs/**/*.mdwithfail: true. A broken relative link now fails CI.linkcheck-external(advisory): full-repo external URL check withfail: false(unchanged behavior; avoids flaky external 403/timeouts blocking PRs).GHOST_IN_THE_MACHINE.md— submission-template evidence entries that pointed at non-existent./evidence/*paths are now plain code spans (paths for the submitter to fill), not markdown links.Audit of the five linked issues
All five were already fixed in
README.mdrelative links onmain(verified against this tree):mainhttps://rustchain.org/api/tokenomicsGET /epochinsteadhttps://rustchain.org/bcos/in READMEBCOS.mddocs/mining.mdMINING_GUIDE.md)docs/attestation-pipeline.md,docs/pay-out-ledger.md, sprint HN linkLocal fence-aware relative-link scan over
README.md+ top-level*.md+docs/**/*.md: 0 missing file targets (directory links such asintegrations/,miners/,miners/linux/resolve to existing tracked directories).CI demonstration
lychee --offline ... -- './README.md' './*.md' './docs/**/*.md'withfail: true.linkcheck-relativered and blocks merge.linkcheck-external.Closes #7910
Closes #7908
Closes #7886
Closes #7885
Closes #7792
Wallet:
bc1qt26njj9uz20hprpe2de9h7z7lhkr0vrsc6sp3t